2024-03-06 06:13:12

by Yang Jialong 杨佳龙

Subject: [PATCH v3 0/2] Support uncore NI-700 Performance Monitor

1.
The MAINTAINERS file should be in dt-bindings or drivers?
It's needed by the two subpatchs.
I place it in dt-bindings. So I receive the warning in driver patch.

2.
When using the new macro DEFINE_FREE(), we should ended it without ';'.
So there is one warning asking me to indentation next statement.

3.
If the file vendor-prefixes.yaml should be submit solely?

JiaLong.Yang (3):
dt-bindings: Add HEXIN Technologies Co., Ltd. vendor prefix
dt-bindings: perf: Support uncore NI-700 PMU
perf/hx_arm_ni: Support uncore NI-700 PMU

.../bindings/perf/hexin,c2000-arm-ni.yaml | 51 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
MAINTAINERS | 6 +
drivers/perf/Kconfig | 11 +
drivers/perf/Makefile | 1 +
drivers/perf/hx_arm_ni.c | 1240 +++++++++++++++++
6 files changed, 1311 insertions(+)
create mode 100644 Documentation/devicetree/bindings/perf/hexin,
c2000-arm-ni.yaml
create mode 100644 drivers/perf/hx_arm_ni.c

--
2.25.1

2024-05-03 13:12:02

by Will Deacon

Subject: Re: [PATCH v3 0/2] Support uncore NI-700 Performance Monitor

On Wed, Mar 06, 2024 at 02:16:00PM +0800, JiaLong.Yang wrote:
> 1.
> The MAINTAINERS file should be in dt-bindings or drivers?
> It's needed by the two subpatchs.
> I place it in dt-bindings. So I receive the warning in driver patch.
>
> 2.
> When using the new macro DEFINE_FREE(), we should ended it without ';'.
> So there is one warning asking me to indentation next statement.
>
> 3.
> If the file vendor-prefixes.yaml should be submit solely?
>
> JiaLong.Yang (3):
> dt-bindings: Add HEXIN Technologies Co., Ltd. vendor prefix
> dt-bindings: perf: Support uncore NI-700 PMU
> perf/hx_arm_ni: Support uncore NI-700 PMU

Please can you take a look at Robin's series for this IP?

https://lore.kernel.org/r/[email protected]

Thanks,

Will