2024-05-03 23:24:08

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'

From: "Dr. David Alan Gilbert" <[email protected]>

I think the last use of this list was removed by
commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
handling").

Build tested only.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/scsi/scsi_transport_iscsi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index af3ac6346796b..123b861d2a9fb 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -1603,7 +1603,6 @@ static DEFINE_MUTEX(rx_queue_mutex);
static LIST_HEAD(sesslist);
static DEFINE_SPINLOCK(sesslock);
static LIST_HEAD(connlist);
-static LIST_HEAD(connlist_err);
static DEFINE_SPINLOCK(connlock);

static uint32_t iscsi_conn_get_sid(struct iscsi_cls_conn *conn)
--
2.44.0



2024-05-06 20:52:34

by Mike Christie

[permalink] [raw]
Subject: Re: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'

On 5/3/24 6:23 PM, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> I think the last use of this list was removed by
> commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
> handling").
>
> Build tested only.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/scsi/scsi_transport_iscsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index af3ac6346796b..123b861d2a9fb 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -1603,7 +1603,6 @@ static DEFINE_MUTEX(rx_queue_mutex);
> static LIST_HEAD(sesslist);
> static DEFINE_SPINLOCK(sesslock);
> static LIST_HEAD(connlist);
> -static LIST_HEAD(connlist_err);
> static DEFINE_SPINLOCK(connlock);
>
> static uint32_t iscsi_conn_get_sid(struct iscsi_cls_conn *conn)

Reviewed-by: Mike Christie <[email protected]>

2024-05-07 01:40:12

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'


> I think the last use of this list was removed by
> commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
> handling").
>
> Build tested only.

Applied to 6.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering