2024-05-01 09:51:16

by Christophe JAILLET

Subject: [PATCH] iio: multiplexer: Remove an unused field in struct mux

In "struct mux", the 'indio_dev' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
category and iio-mux driver") but was never used.
---
drivers/iio/multiplexer/iio-mux.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
index edd8c69f6d2e..2953403bef53 100644
--- a/drivers/iio/multiplexer/iio-mux.c
+++ b/drivers/iio/multiplexer/iio-mux.c
@@ -30,7 +30,6 @@ struct mux {
int cached_state;
struct mux_control *control;
struct iio_channel *parent;
- struct iio_dev *indio_dev;
struct iio_chan_spec *chan;
struct iio_chan_spec_ext_info *ext_info;
struct mux_child *child;
--
2.44.0

2024-05-04 11:41:55

by Jonathan Cameron

Subject: Re: [PATCH] iio: multiplexer: Remove an unused field in struct mux

On Wed, 1 May 2024 11:41:54 +0200
Christophe JAILLET <[email protected]> wrote:

> In "struct mux", the 'indio_dev' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
Applied,

Thanks,

> ---
> Compile tested only.
>
> It was added in the initial commit 7ba9df54b091 ("iio: multiplexer: new iio
> category and iio-mux driver") but was never used.
> ---
> drivers/iio/multiplexer/iio-mux.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
> index edd8c69f6d2e..2953403bef53 100644
> --- a/drivers/iio/multiplexer/iio-mux.c
> +++ b/drivers/iio/multiplexer/iio-mux.c
> @@ -30,7 +30,6 @@ struct mux {
> int cached_state;
> struct mux_control *control;
> struct iio_channel *parent;
> - struct iio_dev *indio_dev;
> struct iio_chan_spec *chan;
> struct iio_chan_spec_ext_info *ext_info;
> struct mux_child *child;