2024-05-06 14:09:07

by Takashi Iwai

[permalink] [raw]
Subject: [PATCH] ACPI: video: Add backlight=native quirk for Lenovo Slim 7 16ARH7

Lenovo Slim 7 16ARH7 is a machine with switchable graphics between AMD
and Nvidia, and the backlight can't be adjusted properly unless
acpi_backlight=native is passed. Although nvidia-wmi-backlight is
present and loaded, this doesn't work as expected at all.

For making it working as default, add the corresponding quirk entry
with a DMI matching "LENOVO" "82UX".

Link: https://bugzilla.suse.com/show_bug.cgi?id=1217750
Signed-off-by: Takashi Iwai <[email protected]>
---
drivers/acpi/video_detect.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 9fdcc620c652..2cc3821b2b16 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -497,6 +497,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "82BK"),
},
},
+ {
+ .callback = video_detect_force_native,
+ /* Lenovo Slim 7 16ARH7 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "82UX"),
+ },
+ },
{
.callback = video_detect_force_native,
/* Lenovo ThinkPad X131e (3371 AMD version) */
--
2.43.0



2024-05-07 12:10:10

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: video: Add backlight=native quirk for Lenovo Slim 7 16ARH7

On Mon, May 6, 2024 at 4:08 PM Takashi Iwai <[email protected]> wrote:
>
> Lenovo Slim 7 16ARH7 is a machine with switchable graphics between AMD
> and Nvidia, and the backlight can't be adjusted properly unless
> acpi_backlight=native is passed. Although nvidia-wmi-backlight is
> present and loaded, this doesn't work as expected at all.
>
> For making it working as default, add the corresponding quirk entry
> with a DMI matching "LENOVO" "82UX".
>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1217750
> Signed-off-by: Takashi Iwai <[email protected]>
> ---
> drivers/acpi/video_detect.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 9fdcc620c652..2cc3821b2b16 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -497,6 +497,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "82BK"),
> },
> },
> + {
> + .callback = video_detect_force_native,
> + /* Lenovo Slim 7 16ARH7 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "82UX"),
> + },
> + },
> {
> .callback = video_detect_force_native,
> /* Lenovo ThinkPad X131e (3371 AMD version) */
> --

Applied as 6.10 material, thanks!