2024-05-09 00:09:24

by Dr. David Alan Gilbert

Subject: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'

From: "Dr. David Alan Gilbert" <[email protected]>

'acpi_handle_node' is unused since
Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/acpi/pci_root.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index 58b89b8d950ed..59e6955e24edb 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
}
EXPORT_SYMBOL_GPL(acpi_pci_find_root);

-struct acpi_handle_node {
- struct list_head node;
- acpi_handle handle;
-};
-
/**
* acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
* @handle: the handle in question
--
2.45.0

2024-05-09 10:58:05

by Jonathan Cameron

Subject: Re: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'

On Thu, 9 May 2024 01:08:58 +0100
[email protected] wrote:

> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'acpi_handle_node' is unused since
> Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

FWIW, indeed unused.

Reviewed-by: Jonathan Cameron <[email protected]>
> ---
> drivers/acpi/pci_root.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index 58b89b8d950ed..59e6955e24edb 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> }
> EXPORT_SYMBOL_GPL(acpi_pci_find_root);
>
> -struct acpi_handle_node {
> - struct list_head node;
> - acpi_handle handle;
> -};
> -
> /**
> * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> * @handle: the handle in question

2024-05-23 15:10:29

by Dr. David Alan Gilbert

Subject: Re: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'

* Jonathan Cameron ([email protected]) wrote:
> On Thu, 9 May 2024 01:08:58 +0100
> [email protected] wrote:
>
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'acpi_handle_node' is unused since
> > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
>
> FWIW, indeed unused.
>
> Reviewed-by: Jonathan Cameron <[email protected]>

Thanks; any idea who would pick this up?

Dave

> > ---
> > drivers/acpi/pci_root.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > index 58b89b8d950ed..59e6955e24edb 100644
> > --- a/drivers/acpi/pci_root.c
> > +++ b/drivers/acpi/pci_root.c
> > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> > }
> > EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> >
> > -struct acpi_handle_node {
> > - struct list_head node;
> > - acpi_handle handle;
> > -};
> > -
> > /**
> > * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> > * @handle: the handle in question
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/

2024-06-06 19:56:45

by Bjorn Helgaas

Subject: Re: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'

On Thu, May 23, 2024 at 03:10:05PM +0000, Dr. David Alan Gilbert wrote:
> * Jonathan Cameron ([email protected]) wrote:
> > On Thu, 9 May 2024 01:08:58 +0100
> > [email protected] wrote:
> >
> > > From: "Dr. David Alan Gilbert" <[email protected]>
> > >
> > > 'acpi_handle_node' is unused since
> > > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > > Remove it.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> >
> > FWIW, indeed unused.
> >
> > Reviewed-by: Jonathan Cameron <[email protected]>
>
> Thanks; any idea who would pick this up?

Applied with Jonathan's reviewed-by to pci/misc for v6.11, thanks!

Rafael, let me know if you want this instead. Easy for me to drop if
you do.

> > > ---
> > > drivers/acpi/pci_root.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > > index 58b89b8d950ed..59e6955e24edb 100644
> > > --- a/drivers/acpi/pci_root.c
> > > +++ b/drivers/acpi/pci_root.c
> > > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> > > }
> > > EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> > >
> > > -struct acpi_handle_node {
> > > - struct list_head node;
> > > - acpi_handle handle;
> > > -};
> > > -
> > > /**
> > > * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> > > * @handle: the handle in question
> >
> >
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/