2024-05-10 06:11:57

by Youling Tang

Subject: [PATCH] bcachefs: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method

From: Youling Tang <[email protected]>

Since commit a2ad63daa88b ("VFS: add FMODE_CAN_ODIRECT file flag") file
systems can just set the FMODE_CAN_ODIRECT flag at open time instead of
wiring up a dummy direct_IO method to indicate support for direct I/O.
Do that for bcachefs so that noop_direct_IO can eventually be removed.

Similar to commit b29434999371 ("xfs: set FMODE_CAN_ODIRECT instead of
a dummy direct_IO method").

Signed-off-by: Youling Tang <[email protected]>
---
fs/bcachefs/fs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
index a8d71cec1c17..7ef41ce2d8c6 100644
--- a/fs/bcachefs/fs.c
+++ b/fs/bcachefs/fs.c
@@ -1142,6 +1142,8 @@ static int bch2_open(struct inode *vinode, struct file *file)
return ret;
}

+ file->f_mode |= FMODE_CAN_ODIRECT;
+
return generic_file_open(vinode, file);
}

@@ -1234,7 +1236,6 @@ static const struct address_space_operations bch_address_space_operations = {
.write_end = bch2_write_end,
.invalidate_folio = bch2_invalidate_folio,
.release_folio = bch2_release_folio,
- .direct_IO = noop_direct_IO,
#ifdef CONFIG_MIGRATION
.migrate_folio = filemap_migrate_folio,
#endif
--
2.34.1

2024-05-13 12:31:19

by Brian Foster

Subject: Re: [PATCH] bcachefs: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method

On Fri, May 10, 2024 at 02:10:58PM +0800, Youling Tang wrote:
> From: Youling Tang <[email protected]>
>
> Since commit a2ad63daa88b ("VFS: add FMODE_CAN_ODIRECT file flag") file
> systems can just set the FMODE_CAN_ODIRECT flag at open time instead of
> wiring up a dummy direct_IO method to indicate support for direct I/O.
> Do that for bcachefs so that noop_direct_IO can eventually be removed.
>
> Similar to commit b29434999371 ("xfs: set FMODE_CAN_ODIRECT instead of
> a dummy direct_IO method").
>
> Signed-off-by: Youling Tang <[email protected]>
> ---

Seems straightforward:

Reviewed-by: Brian Foster <[email protected]>

> fs/bcachefs/fs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c
> index a8d71cec1c17..7ef41ce2d8c6 100644
> --- a/fs/bcachefs/fs.c
> +++ b/fs/bcachefs/fs.c
> @@ -1142,6 +1142,8 @@ static int bch2_open(struct inode *vinode, struct file *file)
> return ret;
> }
>
> + file->f_mode |= FMODE_CAN_ODIRECT;
> +
> return generic_file_open(vinode, file);
> }
>
> @@ -1234,7 +1236,6 @@ static const struct address_space_operations bch_address_space_operations = {
> .write_end = bch2_write_end,
> .invalidate_folio = bch2_invalidate_folio,
> .release_folio = bch2_release_folio,
> - .direct_IO = noop_direct_IO,
> #ifdef CONFIG_MIGRATION
> .migrate_folio = filemap_migrate_folio,
> #endif
> --
> 2.34.1
>
>