On Sat, May 11, 2024 at 11:44:56AM +0530, Kanak Shilledar wrote:
> diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml
> new file mode 100644
> index 000000000000..94da68792194
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/brcm,bcm2835-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM2835 SPI0 controller
> +
> +maintainers:
> + - Florian Fainelli <[email protected]>
> Signed-off-by: Kanak Shilledar <[email protected]>
> + - Kanak Shilledar <[email protected]>
Why didn't you use protonmail for both?
Otherwise, this looks fine.
Thanks,
Conor.
> + - Stefan Wahren <[email protected]>
> +
> +allOf:
> + - $ref: spi-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,bcm2835-spi
> + - brcm,bcm2711-spi
> + - brcm,bcm7211-spi
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi@20204000 {
> + compatible = "brcm,bcm2835-spi";
> + reg = <0x7e204000 0x1000>;
> + interrupts = <2 22>;
> + clocks = <&clk_spi>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> --
> 2.34.1
>
On Mon, May 13, 2024 at 05:17:20PM +0100, Conor Dooley wrote:
> On Sat, May 11, 2024 at 11:44:56AM +0530, Kanak Shilledar wrote:
> > diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml
> > new file mode 100644
> > index 000000000000..94da68792194
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-spi.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/brcm,bcm2835-spi.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Broadcom BCM2835 SPI0 controller
> > +
> > +maintainers:
> > + - Florian Fainelli <[email protected]>
>
>
> > Signed-off-by: Kanak Shilledar <[email protected]>
> > + - Kanak Shilledar <[email protected]>
>
> Why didn't you use protonmail for both?
>
> Otherwise, this looks fine.
Ordinarily, I'd not care, but given it's proton I have an ulterior
motive :)