Subject: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()

From: Nikita Shubin <[email protected]>

Fix missing kmem_cache_destroy() for ioat_sed_cache in
ioat_exit_module().

Noticed via:

```
modprobe ioatdma
rmmod ioatdma
modprobe ioatdma
debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
```

Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
Signed-off-by: Nikita Shubin <[email protected]>
---
drivers/dma/ioat/init.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
index 9c364e92cb82..61329c279040 100644
--- a/drivers/dma/ioat/init.c
+++ b/drivers/dma/ioat/init.c
@@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
static void __exit ioat_exit_module(void)
{
pci_unregister_driver(&ioat_pci_driver);
+ kmem_cache_destroy(ioat_sed_cache);
kmem_cache_destroy(ioat_cache);
}
module_exit(ioat_exit_module);

---
base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
change-id: 20240514-ioatdma_fixes-7460f4fd7d51

Best regards,
--
Nikita Shubin <[email protected]>




2024-05-14 15:38:33

by Dave Jiang

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()



On 5/14/24 3:52 AM, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <[email protected]>
>
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
>
> Noticed via:
>
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
>
> Fixes: c0f28ce66ecf ("dmaengine: ioatdma: move all the init routines")
> Signed-off-by: Nikita Shubin <[email protected]>

Thanks!

Acked-by: Dave Jiang <[email protected]>

> ---
> drivers/dma/ioat/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index 9c364e92cb82..61329c279040 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -1445,6 +1445,7 @@ module_init(ioat_init_module);
> static void __exit ioat_exit_module(void)
> {
> pci_unregister_driver(&ioat_pci_driver);
> + kmem_cache_destroy(ioat_sed_cache);
> kmem_cache_destroy(ioat_cache);
> }
> module_exit(ioat_exit_module);
>
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240514-ioatdma_fixes-7460f4fd7d51
>
> Best regards,

2024-06-11 18:29:06

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: ioatdma: Fix missing kmem_cache_destroy()


On Tue, 14 May 2024 13:52:31 +0300, Nikita Shubin wrote:
> Fix missing kmem_cache_destroy() for ioat_sed_cache in
> ioat_exit_module().
>
> Noticed via:
>
> ```
> modprobe ioatdma
> rmmod ioatdma
> modprobe ioatdma
> debugfs: Directory 'ioat_sed_ent' with parent 'slab' already present!
> ```
>
> [...]

Applied, thanks!

[1/1] dmaengine: ioatdma: Fix missing kmem_cache_destroy()
commit: 5422145d0b749ad554ada772133b9b20f9fb0ec8

Best regards,
--
Vinod Koul <[email protected]>