2024-05-17 07:09:03

by Jani Nikula

Subject: Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

On Thu, 16 May 2024, Steven Rostedt <[email protected]> wrote:
> There's over 700 users of __assign_str() and because coccinelle does not
> handle the TRACE_EVENT() macro I ended up using the following sed script:
>
> git grep -l __assign_str | while read a ; do
> sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
> mv /tmp/test-file $a;
> done

Try 'sed -i' ;)

> .../drm/i915/display/intel_display_trace.h | 56 ++++-----

On i915,

Acked-by: Jani Nikula <[email protected]>

--
Jani Nikula, Intel

2024-05-17 14:15:50

by Steven Rostedt

Subject: Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

On Fri, 17 May 2024 10:08:51 +0300
Jani Nikula <[email protected]> wrote:

> On Thu, 16 May 2024, Steven Rostedt <[email protected]> wrote:
> > There's over 700 users of __assign_str() and because coccinelle does not
> > handle the TRACE_EVENT() macro I ended up using the following sed script:
> >
> > git grep -l __assign_str | while read a ; do
> > sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
> > mv /tmp/test-file $a;
> > done
>
> Try 'sed -i' ;)

I've always been nervous about trusting -i ;-)

>
> > .../drm/i915/display/intel_display_trace.h | 56 ++++-----
>
> On i915,
>
> Acked-by: Jani Nikula <[email protected]>
>

Thanks,

-- Steve