2024-02-15 13:42:02

by Jan Kiszka

Subject: [PATCH v2] dt-bindings: PCI: ti,am65: Fix remaining binding warnings

From: Jan Kiszka <[email protected]>

This adds the missing num-viewport, phys and phy-name properties to the
schema. Based on driver code, num-viewport is required for the root
complex, phys are optional. Their number corresponds to the number of
lanes. The AM65x supports up to 2 lanes.

Signed-off-by: Jan Kiszka <[email protected]>

---
Changes in v2:
- limit phy-names to pcie-phy[0-1]
- fix schema-checking of example
---
.../bindings/pci/ti,am65-pci-host.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
index a20dccbafd94..c54d4e57d089 100644
--- a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
@@ -55,6 +55,20 @@ properties:

dma-coherent: true

+ num-viewport:
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ phys:
+ description: per-lane PHYs
+ minItems: 1
+ maxItems: 2
+
+ phy-names:
+ minItems: 1
+ maxItems: 2
+ items:
+ pattern: '^pcie-phy[0-1]$'
+
required:
- compatible
- reg
@@ -74,6 +88,7 @@ then:
- dma-coherent
- power-domains
- msi-map
+ - num-viewport

unevaluatedProperties: false

@@ -81,6 +96,7 @@ examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/phy/phy.h>
#include <dt-bindings/soc/ti,sci_pm_domain.h>

pcie0_rc: pcie@5500000 {
@@ -98,9 +114,13 @@ examples:
ti,syscon-pcie-id = <&scm_conf 0x0210>;
ti,syscon-pcie-mode = <&scm_conf 0x4060>;
bus-range = <0x0 0xff>;
+ num-viewport = <16>;
max-link-speed = <2>;
dma-coherent;
interrupts = <GIC_SPI 340 IRQ_TYPE_EDGE_RISING>;
msi-map = <0x0 &gic_its 0x0 0x10000>;
device_type = "pci";
+ num-lanes = <1>;
+ phys = <&serdes0 PHY_TYPE_PCIE 0>;
+ phy-names = "pcie-phy0";
};
--
2.35.3

2024-02-22 23:35:42

by Rob Herring (Arm)

Subject: Re: [PATCH v2] dt-bindings: PCI: ti,am65: Fix remaining binding warnings

On Thu, 15 Feb 2024 13:55:56 +0100, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> This adds the missing num-viewport, phys and phy-name properties to the
> schema. Based on driver code, num-viewport is required for the root
> complex, phys are optional. Their number corresponds to the number of
> lanes. The AM65x supports up to 2 lanes.
>
> Signed-off-by: Jan Kiszka <[email protected]>
>
> ---
> Changes in v2:
> - limit phy-names to pcie-phy[0-1]
> - fix schema-checking of example
> ---
> .../bindings/pci/ti,am65-pci-host.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2024-05-17 10:43:05

by Krzysztof Wilczyński

Subject: Re: [PATCH v2] dt-bindings: PCI: ti,am65: Fix remaining binding warnings

Hello,

> This adds the missing num-viewport, phys and phy-name properties to the
> schema. Based on driver code, num-viewport is required for the root
> complex, phys are optional. Their number corresponds to the number of
> lanes. The AM65x supports up to 2 lanes.

Applied to dt-bindings, thank you!

[1/1] dt-bindings: PCI: ti,am65: Fix remaining binding warnings
https://git.kernel.org/pci/pci/c/64e098b59b8a

Krzysztof