2024-05-21 07:52:34

by Anastasia Belova

Subject: [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset

flite_hw_reset is called in fimc_lite_resume with spinlock
acquired that is forbidden. Replace usleep_range with udelay.

Fixes: 2b511edb986f ("[media] s5p-fimc: Add FIMC-LITE register definitions")
Signed-off-by: Anastasia Belova <[email protected]>
---
drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
index 2483277a6cb0..f1e7375c9a5f 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
@@ -30,7 +30,7 @@ void flite_hw_reset(struct fimc_lite *dev)
cfg = readl(dev->regs + FLITE_REG_CIGCTRL);
if (cfg & FLITE_REG_CIGCTRL_SWRST_RDY)
break;
- usleep_range(1000, 5000);
+ udelay(1000);
}

cfg |= FLITE_REG_CIGCTRL_SWRST;
--
2.30.2

2024-05-23 09:32:07

by Krzysztof Kozlowski

Subject: Re: [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset

On 21/05/2024 09:36, Anastasia Belova wrote:
> flite_hw_reset is called in fimc_lite_resume with spinlock
> acquired that is forbidden. Replace usleep_range with udelay.
>
> Fixes: 2b511edb986f ("[media] s5p-fimc: Add FIMC-LITE register definitions")
> Signed-off-by: Anastasia Belova <[email protected]>
> ---
> drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
> index 2483277a6cb0..f1e7375c9a5f 100644
> --- a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
> +++ b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
> @@ -30,7 +30,7 @@ void flite_hw_reset(struct fimc_lite *dev)
> cfg = readl(dev->regs + FLITE_REG_CIGCTRL);
> if (cfg & FLITE_REG_CIGCTRL_SWRST_RDY)
> break;
> - usleep_range(1000, 5000);
> + udelay(1000);

I think the code is rather wrong in fimc_lite_resume() - this should be
called outside of spinlock, thus usleep is ok.

Best regards,
Krzysztof