2024-05-23 00:29:27

by Dr. David Alan Gilbert

Subject: [PATCH] Input: tca6416 remove unused struct 'tca6416_drv_data'

From: "Dr. David Alan Gilbert" <[email protected]>

'tca6416_drv_data' is unused since the original
commit 30ba3ead0576 ("Input: add keypad driver for keys interfaced to
TCA6416").
Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/input/keyboard/tca6416-keypad.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/input/keyboard/tca6416-keypad.c b/drivers/input/keyboard/tca6416-keypad.c
index 677bc4baa5d1..b2060229bd0f 100644
--- a/drivers/input/keyboard/tca6416-keypad.c
+++ b/drivers/input/keyboard/tca6416-keypad.c
@@ -32,11 +32,6 @@ static const struct i2c_device_id tca6416_id[] = {
};
MODULE_DEVICE_TABLE(i2c, tca6416_id);

-struct tca6416_drv_data {
- struct input_dev *input;
- struct tca6416_button data[];
-};
-
struct tca6416_keypad_chip {
uint16_t reg_output;
uint16_t reg_direction;
--
2.45.1

2024-05-24 16:58:40

by Dr. David Alan Gilbert

Subject: Re: [PATCH] Input: tca6416 remove unused struct 'tca6416_drv_data'

* [email protected] ([email protected]) wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'tca6416_drv_data' is unused since the original
> commit 30ba3ead0576 ("Input: add keypad driver for keys interfaced to
> TCA6416").
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Oops, looks like Christophe got there first!

Dave

> ---
> drivers/input/keyboard/tca6416-keypad.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/input/keyboard/tca6416-keypad.c b/drivers/input/keyboard/tca6416-keypad.c
> index 677bc4baa5d1..b2060229bd0f 100644
> --- a/drivers/input/keyboard/tca6416-keypad.c
> +++ b/drivers/input/keyboard/tca6416-keypad.c
> @@ -32,11 +32,6 @@ static const struct i2c_device_id tca6416_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, tca6416_id);
>
> -struct tca6416_drv_data {
> - struct input_dev *input;
> - struct tca6416_button data[];
> -};
> -
> struct tca6416_keypad_chip {
> uint16_t reg_output;
> uint16_t reg_direction;
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/