2024-05-23 17:47:58

by Denis Benato

Subject: [PATCH 1/1] iio: imu: bmi323: Use iio read_acpi_mount_matrix() helper

bmi150-accel and bmi323-imu are declared in an almost identical way in the ACPI and in some devices such as the Asus RC71L the "ROTM" property can be found: parse and use the ACPI-defined mount-matrix.

Co-developed-by: Luke D. Jones <[email protected]>
Co-developed-by: Jonathan LoBue <[email protected]>
Signed-off-by: Denis Benato <[email protected]>
---
drivers/iio/imu/bmi323/bmi323_core.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
index 5d42ab9b176a..b391e5e701b1 100644
--- a/drivers/iio/imu/bmi323/bmi323_core.c
+++ b/drivers/iio/imu/bmi323/bmi323_core.c
@@ -2083,9 +2083,11 @@ int bmi323_core_probe(struct device *dev)
if (ret)
return -EINVAL;

- ret = iio_read_mount_matrix(dev, &data->orientation);
- if (ret)
- return ret;
+ if (!iio_read_acpi_mount_matrix(dev, &data->orientation, "ROTM")) {
+ ret = iio_read_mount_matrix(dev, &data->orientation);
+ if (ret)
+ return ret;
+ }

indio_dev->name = "bmi323-imu";
indio_dev->info = &bmi323_info;
--
2.44.0

2024-05-26 12:24:51

by Jonathan Cameron

Subject: Re: [PATCH 1/1] iio: imu: bmi323: Use iio read_acpi_mount_matrix() helper

On Thu, 23 May 2024 19:47:36 +0200
Denis Benato <[email protected]> wrote:

> bmi150-accel and bmi323-imu are declared in an almost identical way in the ACPI and in some devices such as the Asus RC71L the "ROTM" property can be found: parse and use the ACPI-defined mount-matrix.
>
> Co-developed-by: Luke D. Jones <[email protected]>
> Co-developed-by: Jonathan LoBue <[email protected]>
> Signed-off-by: Denis Benato <[email protected]>
Applied.

Thanks,

Jonathan

> ---
> drivers/iio/imu/bmi323/bmi323_core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
> index 5d42ab9b176a..b391e5e701b1 100644
> --- a/drivers/iio/imu/bmi323/bmi323_core.c
> +++ b/drivers/iio/imu/bmi323/bmi323_core.c
> @@ -2083,9 +2083,11 @@ int bmi323_core_probe(struct device *dev)
> if (ret)
> return -EINVAL;
>
> - ret = iio_read_mount_matrix(dev, &data->orientation);
> - if (ret)
> - return ret;
> + if (!iio_read_acpi_mount_matrix(dev, &data->orientation, "ROTM")) {
> + ret = iio_read_mount_matrix(dev, &data->orientation);
> + if (ret)
> + return ret;
> + }
>
> indio_dev->name = "bmi323-imu";
> indio_dev->info = &bmi323_info;