2024-05-23 23:23:36

by Jeff Johnson

Subject: [PATCH] firewire: add missing MODULE_DESCRIPTION() to test modules

Fix the 'make W=1' warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/uapi-test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/packet-serdes-test.o

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/firewire/packet-serdes-test.c | 1 +
drivers/firewire/uapi-test.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/firewire/packet-serdes-test.c b/drivers/firewire/packet-serdes-test.c
index f93c966e794d..e83b1fece780 100644
--- a/drivers/firewire/packet-serdes-test.c
+++ b/drivers/firewire/packet-serdes-test.c
@@ -579,4 +579,5 @@ static struct kunit_suite packet_serdes_test_suite = {
};
kunit_test_suite(packet_serdes_test_suite);

+MODULE_DESCRIPTION("FireWire packet serialization/deserialization unit test suite");
MODULE_LICENSE("GPL");
diff --git a/drivers/firewire/uapi-test.c b/drivers/firewire/uapi-test.c
index 2fcbede4fab1..bc3f10a2e516 100644
--- a/drivers/firewire/uapi-test.c
+++ b/drivers/firewire/uapi-test.c
@@ -86,4 +86,5 @@ static struct kunit_suite structure_layout_test_suite = {
};
kunit_test_suite(structure_layout_test_suite);

+MODULE_DESCRIPTION("FireWire UAPI unit test suite");
MODULE_LICENSE("GPL");

---
base-commit: 5c4069234f68372e80e4edfcce260e81fd9da007
change-id: 20240523-md-firewire-uapi-test-08fb0a9e18de

2024-05-24 03:40:40

by Takashi Sakamoto

Subject: Re: [PATCH] firewire: add missing MODULE_DESCRIPTION() to test modules

Hi,

Thank you for your sending the patch.

On Thu, May 23, 2024 at 04:22:34PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/uapi-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/packet-serdes-test.o
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/firewire/packet-serdes-test.c | 1 +
> drivers/firewire/uapi-test.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/firewire/packet-serdes-test.c b/drivers/firewire/packet-serdes-test.c
> index f93c966e794d..e83b1fece780 100644
> --- a/drivers/firewire/packet-serdes-test.c
> +++ b/drivers/firewire/packet-serdes-test.c
> @@ -579,4 +579,5 @@ static struct kunit_suite packet_serdes_test_suite = {
> };
> kunit_test_suite(packet_serdes_test_suite);
>
> +MODULE_DESCRIPTION("FireWire packet serialization/deserialization unit test suite");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/firewire/uapi-test.c b/drivers/firewire/uapi-test.c
> index 2fcbede4fab1..bc3f10a2e516 100644
> --- a/drivers/firewire/uapi-test.c
> +++ b/drivers/firewire/uapi-test.c
> @@ -86,4 +86,5 @@ static struct kunit_suite structure_layout_test_suite = {
> };
> kunit_test_suite(structure_layout_test_suite);
>
> +MODULE_DESCRIPTION("FireWire UAPI unit test suite");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 5c4069234f68372e80e4edfcce260e81fd9da007
> change-id: 20240523-md-firewire-uapi-test-08fb0a9e18de

In my opinion, it is not so urgent. I would like to postpone sending it
to mainline until closing the current merge window.


Thanks

Takashi Sakamoto

2024-05-26 22:38:39

by Takashi Sakamoto

Subject: Re: [PATCH] firewire: add missing MODULE_DESCRIPTION() to test modules

On Thu, May 23, 2024 at 04:22:34PM -0700, Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/uapi-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/firewire/packet-serdes-test.o
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/firewire/packet-serdes-test.c | 1 +
> drivers/firewire/uapi-test.c | 1 +
> 2 files changed, 2 insertions(+)

Applied to for-linus branch. I'll send it to mainline in the part of
v6.10-rc1 fixes.


Thanks

Takashi Sakamoto