2024-05-25 00:04:14

by Dr. David Alan Gilbert

Subject: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

From: "Dr. David Alan Gilbert" <[email protected]>

'tegra_vde_h264_frame' has been unused since
commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
support").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
index cfea5572a1b8..d8812fc06c67 100644
--- a/drivers/media/platform/nvidia/tegra-vde/h264.c
+++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
@@ -19,11 +19,6 @@
#define FLAG_B_FRAME 0x1
#define FLAG_REFERENCE 0x2

-struct tegra_vde_h264_frame {
- unsigned int frame_num;
- unsigned int flags;
-};
-
struct tegra_vde_h264_decoder_ctx {
unsigned int dpb_frames_nb;
unsigned int dpb_ref_frames_with_earlier_poc_nb;
--
2.45.1

2024-05-30 12:27:49

by Hans Verkuil

Subject: Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

On 25/05/2024 02:01, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'tegra_vde_h264_frame' has been unused since
> commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> support").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
> index cfea5572a1b8..d8812fc06c67 100644
> --- a/drivers/media/platform/nvidia/tegra-vde/h264.c
> +++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
> @@ -19,11 +19,6 @@
> #define FLAG_B_FRAME 0x1
> #define FLAG_REFERENCE 0x2
>
> -struct tegra_vde_h264_frame {
> - unsigned int frame_num;
> - unsigned int flags;
> -};
> -
> struct tegra_vde_h264_decoder_ctx {
> unsigned int dpb_frames_nb;
> unsigned int dpb_ref_frames_with_earlier_poc_nb;

There is one more reference to this, that also can be dropped:

$ git grep tegra_vde_h264_frame
drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;

Regards,

Hans

2024-05-30 13:28:54

by Dr. David Alan Gilbert

Subject: Re: [PATCH 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

* Hans Verkuil ([email protected]) wrote:
> On 25/05/2024 02:01, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'tegra_vde_h264_frame' has been unused since
> > commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> > support").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > ---
> > drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > index cfea5572a1b8..d8812fc06c67 100644
> > --- a/drivers/media/platform/nvidia/tegra-vde/h264.c
> > +++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
> > @@ -19,11 +19,6 @@
> > #define FLAG_B_FRAME 0x1
> > #define FLAG_REFERENCE 0x2
> >
> > -struct tegra_vde_h264_frame {
> > - unsigned int frame_num;
> > - unsigned int flags;
> > -};
> > -
> > struct tegra_vde_h264_decoder_ctx {
> > unsigned int dpb_frames_nb;
> > unsigned int dpb_ref_frames_with_earlier_poc_nb;
>
> There is one more reference to this, that also can be dropped:
>
> $ git grep tegra_vde_h264_frame
> drivers/media/platform/nvidia/tegra-vde/vde.h:struct tegra_vde_h264_frame;

Thanks! v2 just sent (where I also fixed a typo in the first patch
in the series's title).

Dave

> Regards,
>
> Hans
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/