2024-05-31 03:24:14

by Jeff Johnson

Subject: [PATCH] cdrom: Add missing MODULE_DESCRIPTION()

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o

Add the missing MODULE_DESCRIPTION() macro invocation.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/cdrom/cdrom.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index 20c90ebb3a3f..b6ee9ae36653 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)

module_init(cdrom_init);
module_exit(cdrom_exit);
+MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
MODULE_LICENSE("GPL");

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240530-cdrom-543cdcf21da4

2024-06-01 21:59:48

by Phillip Potter

Subject: Re: [PATCH] cdrom: Add missing MODULE_DESCRIPTION()

On Thu, May 30, 2024 at 08:23:34PM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/cdrom/cdrom.o
>
> Add the missing MODULE_DESCRIPTION() macro invocation.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/cdrom/cdrom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 20c90ebb3a3f..b6ee9ae36653 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3708,4 +3708,5 @@ static void __exit cdrom_exit(void)
>
> module_init(cdrom_init);
> module_exit(cdrom_exit);
> +MODULE_DESCRIPTION("Uniform CD-ROM driver for Linux");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240530-cdrom-543cdcf21da4
>

Hi Jeff,

Thank you for the patch, looks good to me. I will send on for inclusion.

Reviewed-by: Phillip Potter <[email protected]>

Regards,
Phil