2024-06-02 10:17:08

by Thorsten Blum

[permalink] [raw]
Subject: [PATCH] readdir: Remove unused header include

Since commit c512c6918719 ("uaccess: implement a proper
unsafe_copy_to_user() and switch filldir over to it") the header file is
no longer needed.

Signed-off-by: Thorsten Blum <[email protected]>
---
fs/readdir.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/readdir.c b/fs/readdir.c
index 5045e32f1cb6..d6c82421902a 100644
--- a/fs/readdir.c
+++ b/fs/readdir.c
@@ -22,8 +22,6 @@
#include <linux/compat.h>
#include <linux/uaccess.h>

-#include <asm/unaligned.h>
-
/*
* Some filesystems were never converted to '->iterate_shared()'
* and their directory iterators want the inode lock held for
--
2.45.1



2024-06-03 11:07:12

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] readdir: Remove unused header include

On Sun 02-06-24 12:15:35, Thorsten Blum wrote:
> Since commit c512c6918719 ("uaccess: implement a proper
> unsafe_copy_to_user() and switch filldir over to it") the header file is
> no longer needed.
>
> Signed-off-by: Thorsten Blum <[email protected]>

Nice. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/readdir.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 5045e32f1cb6..d6c82421902a 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -22,8 +22,6 @@
> #include <linux/compat.h>
> #include <linux/uaccess.h>
>
> -#include <asm/unaligned.h>
> -
> /*
> * Some filesystems were never converted to '->iterate_shared()'
> * and their directory iterators want the inode lock held for
> --
> 2.45.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2024-06-03 13:49:19

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH] readdir: Remove unused header include

On Sun, 02 Jun 2024 12:15:35 +0200, Thorsten Blum wrote:
> Since commit c512c6918719 ("uaccess: implement a proper
> unsafe_copy_to_user() and switch filldir over to it") the header file is
> no longer needed.
>
>

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] readdir: Remove unused header include
https://git.kernel.org/vfs/vfs/c/c06a4cc368ac