2024-06-04 11:56:17

by Konstantin Taranov

Subject: [PATCH 1/1] RDMA/mana_ib: ignore optional access flags for MRs

From: Konstantin Taranov <[email protected]>

Ignore optional ib_access_flags when an MR is created.

Signed-off-by: Konstantin Taranov <[email protected]>
---
drivers/infiniband/hw/mana/mr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/mana/mr.c b/drivers/infiniband/hw/mana/mr.c
index 4f13423..887b09d 100644
--- a/drivers/infiniband/hw/mana/mr.c
+++ b/drivers/infiniband/hw/mana/mr.c
@@ -112,6 +112,7 @@ struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
"start 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
start, iova, length, access_flags);

+ access_flags &= ~IB_ACCESS_OPTIONAL;
if (access_flags & ~VALID_MR_FLAGS)
return ERR_PTR(-EINVAL);

--
2.43.0

2024-06-04 13:04:10

by Leon Romanovsky

Subject: Re: [PATCH 1/1] RDMA/mana_ib: ignore optional access flags for MRs

On Tue, Jun 04, 2024 at 04:56:02AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <[email protected]>
>
> Ignore optional ib_access_flags when an MR is created.
>
> Signed-off-by: Konstantin Taranov <[email protected]>
> ---
> drivers/infiniband/hw/mana/mr.c | 1 +
> 1 file changed, 1 insertion(+)

Please add Fixes line.

Thanks

>
> diff --git a/drivers/infiniband/hw/mana/mr.c b/drivers/infiniband/hw/mana/mr.c
> index 4f13423..887b09d 100644
> --- a/drivers/infiniband/hw/mana/mr.c
> +++ b/drivers/infiniband/hw/mana/mr.c
> @@ -112,6 +112,7 @@ struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
> "start 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
> start, iova, length, access_flags);
>
> + access_flags &= ~IB_ACCESS_OPTIONAL;
> if (access_flags & ~VALID_MR_FLAGS)
> return ERR_PTR(-EINVAL);
>
> --
> 2.43.0
>