From: "Dr. David Alan Gilbert" <[email protected]>
'rds_ib_dereg_odp_mr' has been unused since the original
commit 2eafa1746f17 ("net/rds: Handle ODP mr
registration/unregistration").
Remove it.
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
net/rds/ib_rdma.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
index 8f070ee7e742..d1cfceeff133 100644
--- a/net/rds/ib_rdma.c
+++ b/net/rds/ib_rdma.c
@@ -40,10 +40,6 @@
#include "rds.h"
struct workqueue_struct *rds_ib_mr_wq;
-struct rds_ib_dereg_odp_mr {
- struct work_struct work;
- struct ib_mr *mr;
-};
static void rds_ib_odp_mr_worker(struct work_struct *work);
--
2.45.1
On Sat, Jun 01, 2024 at 12:33:07AM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
nit: Maybe commit lines are best not line-wrapped.
I'm unsure.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
The above not withstanding, this looks good to me.
Reviewed-by: Simon Horman <[email protected]>
On Sat, 2024-06-01 at 00:33 +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
This patch looks fine to me, the struct is indeed unused at this point.
Thanks for the clean up!
Reviewed-by: Allison Henderson <[email protected]>
> ---
> net/rds/ib_rdma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> index 8f070ee7e742..d1cfceeff133 100644
> --- a/net/rds/ib_rdma.c
> +++ b/net/rds/ib_rdma.c
> @@ -40,10 +40,6 @@
> #include "rds.h"
>
> struct workqueue_struct *rds_ib_mr_wq;
> -struct rds_ib_dereg_odp_mr {
> - struct work_struct work;
> - struct ib_mr *mr;
> -};
>
> static void rds_ib_odp_mr_worker(struct work_struct *work);
>
* Simon Horman ([email protected]) wrote:
> On Sat, Jun 01, 2024 at 12:33:07AM +0100, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'rds_ib_dereg_odp_mr' has been unused since the original
> > commit 2eafa1746f17 ("net/rds: Handle ODP mr
> > registration/unregistration").
>
> nit: Maybe commit lines are best not line-wrapped.
> I'm unsure.
Yeh I wasn't too sure, checkpatch seems to have code
to deal with it, so it is expecting it could be wrapped:
# A commit match can span multiple lines so this block attempts to find a
# complete typical commit on a maximum of 3 lines
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
>
> The above not withstanding, this looks good to me.
>
> Reviewed-by: Simon Horman <[email protected]>
Thanks!
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/