Hi,
Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
applicable. Several existing bindings for these display/GPU/CAM clock
controllers already do it.
No external dependencies, this CAN be applied independently, but require
power-domain-cells in each binding, just like Dmitry's new set is doing.
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
---
Krzysztof Kozlowski (16):
dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml
dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml
dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml
dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml
dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml
dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml
.../bindings/clock/qcom,dispcc-sc8280xp.yaml | 20 ++++----------------
.../bindings/clock/qcom,dispcc-sm6350.yaml | 20 ++++----------------
.../bindings/clock/qcom,dispcc-sm8x50.yaml | 18 ++----------------
.../devicetree/bindings/clock/qcom,gpucc-sdm660.yaml | 20 ++++----------------
.../devicetree/bindings/clock/qcom,gpucc.yaml | 20 ++++----------------
.../bindings/clock/qcom,msm8998-gpucc.yaml | 20 ++++----------------
.../bindings/clock/qcom,qcm2290-dispcc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sc7180-dispcc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sc7280-dispcc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sdm845-dispcc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sm6115-dispcc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sm8450-dispcc.yaml | 20 ++++----------------
.../devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sm8450-videocc.yaml | 20 ++++----------------
.../bindings/clock/qcom,sm8550-dispcc.yaml | 20 ++++----------------
.../devicetree/bindings/clock/qcom,videocc.yaml | 19 +++----------------
16 files changed, 61 insertions(+), 256 deletions(-)
---
base-commit: b0afb900b7d235d879f8e8e4babfe77d9db76f2f
change-id: 20240531-dt-bindings-qcom-gcc-e2955fd60004
Best regards,
--
Krzysztof Kozlowski <[email protected]>
Just like most of clock controllers, the SM6350 display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,dispcc-sm6350.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml
index 8efac3fb159f..a584b4953e68 100644
--- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml
@@ -37,28 +37,16 @@ properties:
- const: dp_phy_pll_link_clk
- const: dp_phy_pll_vco_div_clk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SDM845 Display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sdm845-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
index 719844d7ea11..220f4004f7fd 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
@@ -46,28 +46,16 @@ properties:
- const: dp_link_clk_divsel_ten
- const: dp_vco_divided_clk_src_mux
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the MSM8998 GPU clock controller is
also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,msm8998-gpucc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,msm8998-gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,msm8998-gpucc.yaml
index 7b271ae210a3..b9b218ef9b68 100644
--- a/Documentation/devicetree/bindings/clock/qcom,msm8998-gpucc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,msm8998-gpucc.yaml
@@ -29,28 +29,16 @@ properties:
- const: xo
- const: gpll0
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the QCM2290 Display clock
controller is also some variant of standard Qualcomm GCC, so reference
common qcom,gcc.yaml schema to simplify the binding and unify it with
others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,qcm2290-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,qcm2290-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcm2290-dispcc.yaml
index 4a00f2d41684..243be4f76db3 100644
--- a/Documentation/devicetree/bindings/clock/qcom,qcm2290-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,qcm2290-dispcc.yaml
@@ -37,28 +37,16 @@ properties:
- const: dsi0_phy_pll_out_byteclk
- const: dsi0_phy_pll_out_dsiclk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SM8450 Display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sm8450-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
index 2f22310b08a9..4794c53793a8 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-dispcc.yaml
@@ -40,18 +40,6 @@ properties:
- description: Link clock from DP PHY3
- description: VCO DIV clock from DP PHY3
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
power-domains:
description:
A phandle and PM domain specifier for the MMCX power domain.
@@ -64,13 +52,13 @@ properties:
required:
- compatible
- - reg
- clocks
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SC7180 Display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sc7180-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
index 1c9ce300a435..0d8ea44d8141 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
@@ -37,28 +37,16 @@ properties:
- const: dp_phy_pll_link_clk
- const: dp_phy_pll_vco_div_clk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SC7280 Display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sc7280-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-dispcc.yaml
index c42b0ef61385..23177661be40 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7280-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-dispcc.yaml
@@ -41,28 +41,16 @@ properties:
- const: edp_phy_pll_link_clk
- const: edp_phy_pll_vco_div_clk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SM8550 Display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sm8550-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml
index bad0260764d4..c17035a180db 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml
@@ -45,18 +45,6 @@ properties:
- description: Link clock from DP PHY3
- description: VCO DIV clock from DP PHY3
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
power-domains:
description:
A phandle and PM domain specifier for the MMCX power domain.
@@ -69,13 +57,13 @@ properties:
required:
- compatible
- - reg
- clocks
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SM8450 GPU clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml
index 36974309cf69..3c2cac14e6c3 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml
@@ -34,27 +34,15 @@ properties:
- description: GPLL0 main branch source
- description: GPLL0 div branch source
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SM8450 Video clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sm8450-videocc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
index bad8f019a8d3..74034e3f79b7 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
@@ -21,9 +21,6 @@ properties:
- qcom,sm8450-videocc
- qcom,sm8550-videocc
- reg:
- maxItems: 1
-
clocks:
items:
- description: Board XO source
@@ -39,26 +36,17 @@ properties:
description:
A phandle to an OPP node describing required MMCX performance point.
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
required:
- compatible
- - reg
- clocks
- power-domains
- required-opps
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SC8280xp display clock
controller is also some variant of standard Qualcomm GCC, so reference
common qcom,gcc.yaml schema to simplify the binding and unify it with
others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,dispcc-sc8280xp.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sc8280xp.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sc8280xp.yaml
index 3cb996b2c9d5..ffae037779a1 100644
--- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sc8280xp.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sc8280xp.yaml
@@ -40,31 +40,19 @@ properties:
- description: DSI 1 PLL byte clock
- description: DSI 1 PLL DSI clock
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
power-domains:
items:
- description: MMCX power domain
required:
- compatible
- - reg
- clocks
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SM8150 and others display clock
controllers are also some variant of standard Qualcomm GCC, so reference
common qcom,gcc.yaml schema to simplify the binding and unify it with
others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
index 0d82521a5433..53a5ab319159 100644
--- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
@@ -60,18 +60,6 @@ properties:
- const: dptx2_phy_pll_link_clk
- const: dptx2_phy_pll_vco_div_clk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
power-domains:
description:
A phandle and PM domain specifier for the MMCX power domain.
@@ -84,14 +72,12 @@ properties:
required:
- compatible
- - reg
- clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
allOf:
+ - $ref: qcom,gcc.yaml#
- if:
not:
properties:
@@ -105,7 +91,7 @@ allOf:
clock-names:
maxItems: 7
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.43.0
Just like most of clock controllers, the SM6115 Display clock controller
is also some variant of standard Qualcomm GCC, so reference common
qcom,gcc.yaml schema to simplify the binding and unify it with others.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/qcom,sm6115-dispcc.yaml | 20 ++++----------------
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
index f802a2e7f818..00be36683eb5 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm6115-dispcc.yaml
@@ -28,27 +28,15 @@ properties:
- description: Pixel clock from DSI PHY0
- description: GPLL0 DISP DIV clock from GCC
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- compatible
- - reg
- clocks
- - '#clock-cells'
- - '#reset-cells'
- '#power-domain-cells'
-additionalProperties: false
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
examples:
- |
--
2.43.0
On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
> applicable. Several existing bindings for these display/GPU/CAM clock
> controllers already do it.
The series looks good to me with a single point in mind. You are writing
that dispcc/videocc/etc are a variant of GCC. However GCC is a Global
Clock Controller. What about renaming qcom,gcc.yaml to
qcom,cc-common.yaml ? Then the rest makes total sense to me.
>
> No external dependencies, this CAN be applied independently, but require
> power-domain-cells in each binding, just like Dmitry's new set is doing.
>
> https://lore.kernel.org/all/[email protected]/
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (16):
> dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml
>
> .../bindings/clock/qcom,dispcc-sc8280xp.yaml | 20 ++++----------------
> .../bindings/clock/qcom,dispcc-sm6350.yaml | 20 ++++----------------
> .../bindings/clock/qcom,dispcc-sm8x50.yaml | 18 ++----------------
> .../devicetree/bindings/clock/qcom,gpucc-sdm660.yaml | 20 ++++----------------
> .../devicetree/bindings/clock/qcom,gpucc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,msm8998-gpucc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,qcm2290-dispcc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sc7180-dispcc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sc7280-dispcc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sdm845-dispcc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sm6115-dispcc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sm8450-dispcc.yaml | 20 ++++----------------
> .../devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sm8450-videocc.yaml | 20 ++++----------------
> .../bindings/clock/qcom,sm8550-dispcc.yaml | 20 ++++----------------
> .../devicetree/bindings/clock/qcom,videocc.yaml | 19 +++----------------
> 16 files changed, 61 insertions(+), 256 deletions(-)
> ---
> base-commit: b0afb900b7d235d879f8e8e4babfe77d9db76f2f
> change-id: 20240531-dt-bindings-qcom-gcc-e2955fd60004
>
> Best regards,
> --
> Krzysztof Kozlowski <[email protected]>
>
--
With best wishes
Dmitry
On 31/05/2024 17:14, Dmitry Baryshkov wrote:
> On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
>> applicable. Several existing bindings for these display/GPU/CAM clock
>> controllers already do it.
>
> The series looks good to me with a single point in mind. You are writing
> that dispcc/videocc/etc are a variant of GCC. However GCC is a Global
> Clock Controller.
Yeah, that's simplification from my side and assumption that at first
they designed GCC and then they copied the design to other blocks.
> What about renaming qcom,gcc.yaml to
> qcom,cc-common.yaml ? Then the rest makes total sense to me.
Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so
I would say this should not be a requirement for this patchset.
We can rename, although it always is a bit of churn - git log needs
special option, backporting is a bit trickier.
Best regards,
Krzysztof
On Fri, 31 May 2024 at 18:19, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 31/05/2024 17:14, Dmitry Baryshkov wrote:
> > On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote:
> >> Hi,
> >>
> >> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
> >> applicable. Several existing bindings for these display/GPU/CAM clock
> >> controllers already do it.
> >
> > The series looks good to me with a single point in mind. You are writing
> > that dispcc/videocc/etc are a variant of GCC. However GCC is a Global
> > Clock Controller.
>
> Yeah, that's simplification from my side and assumption that at first
> they designed GCC and then they copied the design to other blocks.
>
> > What about renaming qcom,gcc.yaml to
> > qcom,cc-common.yaml ? Then the rest makes total sense to me.
>
> Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so
> I would say this should not be a requirement for this patchset.
>
> We can rename, although it always is a bit of churn - git log needs
> special option, backporting is a bit trickier.
Ok. For the series:
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry
On Fri, May 31, 2024 at 05:19:19PM GMT, Krzysztof Kozlowski wrote:
> On 31/05/2024 17:14, Dmitry Baryshkov wrote:
> > On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote:
> >> Hi,
> >>
> >> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
> >> applicable. Several existing bindings for these display/GPU/CAM clock
> >> controllers already do it.
> >
> > The series looks good to me with a single point in mind. You are writing
> > that dispcc/videocc/etc are a variant of GCC. However GCC is a Global
> > Clock Controller.
>
> Yeah, that's simplification from my side and assumption that at first
> they designed GCC and then they copied the design to other blocks.
>
That may or may not be the case, who knows... I also don't have a strong
opinion about tying it all to gcc.yaml if that work...
But the claim in the commit messages should the be that we inherit
gcc.yaml because it's convenient, not because all clock controllers are
derived from gcc.
Regards,
Bjorn
> > What about renaming qcom,gcc.yaml to
> > qcom,cc-common.yaml ? Then the rest makes total sense to me.
>
> Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so
> I would say this should not be a requirement for this patchset.
>
> We can rename, although it always is a bit of churn - git log needs
> special option, backporting is a bit trickier.
>
>
> Best regards,
> Krzysztof
>
On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where
> applicable. Several existing bindings for these display/GPU/CAM clock
> controllers already do it.
>
> No external dependencies, this CAN be applied independently, but require
> power-domain-cells in each binding, just like Dmitry's new set is doing.
>
> https://lore.kernel.org/all/[email protected]/
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (16):
> dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml
> dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml
Reviewed-by: Rob Herring (Arm) <[email protected]>