2024-06-05 03:42:06

by Marilene A Garcia

Subject: [PATCH] bcache: Fix compiler warnings

It fixes the following compiler warnings by
using "/*" instead of "/**" in the comments

drivers/md/bcache/request.c:309: warning:
Function parameter or struct member 'bch_data_insert'
not described in 'CLOSURE_CALLBACK'

drivers/md/bcache/request.c:309: warning: expecting
prototype for bch_data_insert(). Prototype was for
CLOSURE_CALLBACK() instead

Signed-off-by: Marilene A Garcia <[email protected]>
---
Hello,
These warnings happen using GCC compiler the command 'make W=1'.

Thank you.

drivers/md/bcache/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index af345dc6fde1..457b9605aff9 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
}
}

-/**
+/*
* bch_data_insert - stick some data in the cache
* @cl: closure pointer.
*
--
2.34.1

2024-06-05 22:28:28

by Marilene A Garcia

Subject: Re: [PATCH] bcache: Fix compiler warnings

On 05/06/2024 00:40, Marilene A Garcia wrote:
> It fixes the following compiler warnings by
> using "/*" instead of "/**" in the comments
>
> drivers/md/bcache/request.c:309: warning:
> Function parameter or struct member 'bch_data_insert'
> not described in 'CLOSURE_CALLBACK'
>
> drivers/md/bcache/request.c:309: warning: expecting
> prototype for bch_data_insert(). Prototype was for
> CLOSURE_CALLBACK() instead
>
> Signed-off-by: Marilene A Garcia <[email protected]>
> ---
> Hello,
> These warnings happen using GCC compiler the command 'make W=1'.
>
> Thank you.
>
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index af345dc6fde1..457b9605aff9 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
> }
> }
>
> -/**
> +/*
> * bch_data_insert - stick some data in the cache
> * @cl: closure pointer.
> *

Hello,
I have realized that even though this change could fix the warning, it
is not the correct fix to it, because it breaks the format of kernel
function comments.

So please discard the patch.
Thank you.