icssg_config.c uses some APIs that are defined in icssg_queue.c.
TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
result the below build error is seen
ERROR: modpost: "icssg_queue_pop"
[drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
ERROR: modpost: "icssg_queue_push"
[drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 487f7323f39a ("net: ti: icssg-prueth: Add helper functions to configure FDB")
Signed-off-by: MD Danish Anwar <[email protected]>
---
Cc: Thorsten Leemhuis <[email protected]>
NOTE: This is only applicable on net-next but not on net as the patch that
introduced this dependency is part of net-next.
drivers/net/ethernet/ti/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/Makefile b/drivers/net/ethernet/ti/Makefile
index 59cd20a38267..79464ad6f1e8 100644
--- a/drivers/net/ethernet/ti/Makefile
+++ b/drivers/net/ethernet/ti/Makefile
@@ -45,6 +45,7 @@ obj-$(CONFIG_TI_ICSSG_PRUETH_SR1) += icssg-prueth-sr1.o
icssg-prueth-sr1-y := icssg/icssg_prueth_sr1.o \
icssg/icssg_common.o \
icssg/icssg_classifier.o \
+ icssg/icssg_queues.o \
icssg/icssg_config.o \
icssg/icssg_mii_cfg.o \
icssg/icssg_stats.o \
base-commit: cd0057ad75116bacf16fea82e48c1db642971136
--
2.34.1
On 05.06.24 05:56, MD Danish Anwar wrote:
> icssg_config.c uses some APIs that are defined in icssg_queue.c.
> TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
> result the below build error is seen
>
> ERROR: modpost: "icssg_queue_pop"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> ERROR: modpost: "icssg_queue_push"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
>
> Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 487f7323f39a ("net: ti: icssg-prueth: Add helper functions to configure FDB")
> Signed-off-by: MD Danish Anwar <[email protected]>
> ---
> Cc: Thorsten Leemhuis <[email protected]>
Thx, seems this did the trick (tested this patch with today's -next and
assuming here that no change fixed it in between).
Reported-and-tested-by: Thorsten Leemhuis <[email protected]>
Closes:
https://lore.kernel.org/all/[email protected]/
Ciao, Thorsten
On Wed, Jun 05, 2024 at 09:26:17AM +0530, MD Danish Anwar wrote:
> icssg_config.c uses some APIs that are defined in icssg_queue.c.
> TI_ICSSG_PRUETH_SR1 uses icssg_config.o but not icssg_queues.o as a
> result the below build error is seen
>
> ERROR: modpost: "icssg_queue_pop"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> ERROR: modpost: "icssg_queue_push"
> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
>
> Fix this by adding icssg_queues.o in TI_ICSSG_PRUETH_SR1
Please take a look at
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
Andrew
---
pw-bot: cr