2024-06-06 10:00:47

by Wenchao Hao

Subject: [PATCH] crash: Remove header files which are included more than once

Following warning is reported, so remove these duplicated header
including:

./kernel/crash_reserve.c: linux/kexec.h is included more than once.

This is just a clean code, no logic changed.

Signed-off-by: Wenchao Hao <[email protected]>
---
kernel/crash_reserve.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/crash_reserve.c b/kernel/crash_reserve.c
index 5b2722a93a48..d3b4cd12bdd1 100644
--- a/kernel/crash_reserve.c
+++ b/kernel/crash_reserve.c
@@ -13,7 +13,6 @@
#include <linux/memory.h>
#include <linux/cpuhotplug.h>
#include <linux/memblock.h>
-#include <linux/kexec.h>
#include <linux/kmemleak.h>

#include <asm/page.h>
--
2.38.1

2024-06-07 06:28:40

by Baoquan He

Subject: Re: [PATCH] crash: Remove header files which are included more than once

On 06/06/24 at 05:14pm, Wenchao Hao wrote:
> Following warning is reported, so remove these duplicated header
> including:
>
> ./kernel/crash_reserve.c: linux/kexec.h is included more than once.
>
> This is just a clean code, no logic changed.
>
> Signed-off-by: Wenchao Hao <[email protected]>
> ---
> kernel/crash_reserve.c | 1 -
> 1 file changed, 1 deletion(-)

I remember someone posted patch to clean this up. Anyway,

Acked-by: Baoquan He <[email protected]>

>
> diff --git a/kernel/crash_reserve.c b/kernel/crash_reserve.c
> index 5b2722a93a48..d3b4cd12bdd1 100644
> --- a/kernel/crash_reserve.c
> +++ b/kernel/crash_reserve.c
> @@ -13,7 +13,6 @@
> #include <linux/memory.h>
> #include <linux/cpuhotplug.h>
> #include <linux/memblock.h>
> -#include <linux/kexec.h>
> #include <linux/kmemleak.h>
>
> #include <asm/page.h>
> --
> 2.38.1
>