2024-06-06 18:40:05

by Masahiro Yamada

Subject: [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o

Building with W=1 incorrectly emits the following warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o

This check should apply only to modules.

Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")
Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/mod/modpost.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 937294ff164f..f48d72d22dc2 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
namespace = get_next_modinfo(&info, "import_ns",
namespace);
}
+
+ if (extra_warn && !get_modinfo(&info, "description"))
+ warn("missing MODULE_DESCRIPTION() in %s\n", modname);
}

- if (extra_warn && !get_modinfo(&info, "description"))
- warn("missing MODULE_DESCRIPTION() in %s\n", modname);
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
symname = remove_dot(info.strtab + sym->st_name);

--
2.43.0

2024-06-06 19:41:08

by Vincenzo Palazzo

Subject: Re: [PATCH] modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o

LGMT, thanks

Reviewed-by: Vincenzo Palazzo <[email protected]>


On Thu, Jun 6, 2024 at 8:39 PM Masahiro Yamada <[email protected]> wrote:
>
> Building with W=1 incorrectly emits the following warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o
>
> This check should apply only to modules.
>
> Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> scripts/mod/modpost.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 937294ff164f..f48d72d22dc2 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
> namespace = get_next_modinfo(&info, "import_ns",
> namespace);
> }
> +
> + if (extra_warn && !get_modinfo(&info, "description"))
> + warn("missing MODULE_DESCRIPTION() in %s\n", modname);
> }
>
> - if (extra_warn && !get_modinfo(&info, "description"))
> - warn("missing MODULE_DESCRIPTION() in %s\n", modname);
> for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
> symname = remove_dot(info.strtab + sym->st_name);
>
> --
> 2.43.0
>