2024-06-09 17:35:17

by Asbjørn Sloth Tønnesen

Subject: [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags()

Change the existing check for unsupported encapsulation control flags,
to use the new helper flow_rule_is_supp_enc_control_flags().

No functional change, only compile tested.

Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]>
---
drivers/net/ethernet/sfc/tc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
index 9d140203e273a..0d93164988fc6 100644
--- a/drivers/net/ethernet/sfc/tc.c
+++ b/drivers/net/ethernet/sfc/tc.c
@@ -387,11 +387,8 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
struct flow_match_control fm;

flow_rule_match_enc_control(rule, &fm);
- if (fm.mask->flags) {
- NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on enc_control.flags %#x",
- fm.mask->flags);
+ if (flow_rule_has_enc_control_flags(fm.mask->flags, extack))
return -EOPNOTSUPP;
- }
if (!IS_ALL_ONES(fm.mask->addr_type)) {
NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported enc addr_type mask %u (key %u)",
fm.mask->addr_type,
--
2.45.1

2024-06-10 19:31:33

by Edward Cree

Subject: Re: [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags()

On 09/06/2024 18:33, Asbjørn Sloth Tønnesen wrote:
> Change the existing check for unsupported encapsulation control flags,
> to use the new helper flow_rule_is_supp_enc_control_flags().
>
> No functional change, only compile tested.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]>

Acked-by: Edward Cree <[email protected]>

> ---
> drivers/net/ethernet/sfc/tc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
> index 9d140203e273a..0d93164988fc6 100644
> --- a/drivers/net/ethernet/sfc/tc.c
> +++ b/drivers/net/ethernet/sfc/tc.c
> @@ -387,11 +387,8 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
> struct flow_match_control fm;
>
> flow_rule_match_enc_control(rule, &fm);
> - if (fm.mask->flags) {
> - NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on enc_control.flags %#x",
> - fm.mask->flags);
> + if (flow_rule_has_enc_control_flags(fm.mask->flags, extack))
> return -EOPNOTSUPP;
> - }
> if (!IS_ALL_ONES(fm.mask->addr_type)) {
> NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported enc addr_type mask %u (key %u)",
> fm.mask->addr_type,
>