The compiled dtb files aren't executable, so install them with 0644 as their
permission mode, instead of defaulting to 0755 as the mode.
Signed-off-by: Dragan Simic <[email protected]>
---
scripts/Makefile.dtbinst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
index 67956f6496a5..9d920419a62c 100644
--- a/scripts/Makefile.dtbinst
+++ b/scripts/Makefile.dtbinst
@@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
dst := $(INSTALL_DTBS_PATH)
quiet_cmd_dtb_install = INSTALL $@
- cmd_dtb_install = install -D $< $@
+ cmd_dtb_install = install -D -m 0644 $< $@
$(dst)/%: $(obj)/%
$(call cmd,dtb_install)
+Cc: [email protected]
+Cc: [email protected]
On 2024-06-09 21:32, Dragan Simic wrote:
> The compiled dtb files aren't executable, so install them with 0644 as
> their
> permission mode, instead of defaulting to 0755 as the mode.
>
> Signed-off-by: Dragan Simic <[email protected]>
Actually, some Linux distributions, including Debian, [1][2] already
include
fixes in their kernel package builds to change the file permissions to
0644.
Thus, let's have this fix propagated into the stable kernels, to allow
such
distributions to remove their downstream fixes.
Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
[1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
[2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
> ---
> scripts/Makefile.dtbinst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
> index 67956f6496a5..9d920419a62c 100644
> --- a/scripts/Makefile.dtbinst
> +++ b/scripts/Makefile.dtbinst
> @@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
> dst := $(INSTALL_DTBS_PATH)
>
> quiet_cmd_dtb_install = INSTALL $@
> - cmd_dtb_install = install -D $< $@
> + cmd_dtb_install = install -D -m 0644 $< $@
>
> $(dst)/%: $(obj)/%
> $(call cmd,dtb_install)
On Mon, Jun 10, 2024 at 12:41:54AM +0200, Dragan Simic wrote:
> +Cc: [email protected]
> +Cc: [email protected]
>
> On 2024-06-09 21:32, Dragan Simic wrote:
> > The compiled dtb files aren't executable, so install them with 0644 as
> > their
> > permission mode, instead of defaulting to 0755 as the mode.
> >
> > Signed-off-by: Dragan Simic <[email protected]>
>
> Actually, some Linux distributions, including Debian, [1][2] already include
> fixes in their kernel package builds to change the file permissions to 0644.
> Thus, let's have this fix propagated into the stable kernels, to allow such
> distributions to remove their downstream fixes.
>
> Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
>
> [1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
> [2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
Hello Greg K-H,
On 2024-06-10 06:19, Greg KH wrote:
> On Mon, Jun 10, 2024 at 12:41:54AM +0200, Dragan Simic wrote:
>> +Cc: [email protected]
>> +Cc: [email protected]
>>
>> On 2024-06-09 21:32, Dragan Simic wrote:
>> > The compiled dtb files aren't executable, so install them with 0644 as
>> > their
>> > permission mode, instead of defaulting to 0755 as the mode.
>> >
>> > Signed-off-by: Dragan Simic <[email protected]>
>>
>> Actually, some Linux distributions, including Debian, [1][2] already
>> include
>> fixes in their kernel package builds to change the file permissions to
>> 0644.
>> Thus, let's have this fix propagated into the stable kernels, to allow
>> such
>> distributions to remove their downstream fixes.
>>
>> Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
>>
>> [1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
>> [2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
>
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
>
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
Thanks for your response. I'll send the v2 with, hopefully, all patch
submission issues addressed.