Signed-off-by: Jiaxun Yang <[email protected]>
---
Changes in v2:
- Write a new binding for this device (Krzysztof)
- Sweep other warnings
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Jiaxun Yang (8):
MIPS: dts: Boston: Add simple-mfd compatible for syscon
MIPS: dts: Boston: Move syscon-reboot node under syscon
MIPS: dts: Boston: Remove unused #interrupt-cells
MIPS: dts: Boston: Add model property
MIPS: dts: Boston: Rename uart node
dt-bindings: mfd: Add img,boston-platform-regs
du-bindings: mips: cpu: Add img,mips compatible
dt-bindings: mips: img: Add devices binding
.../devicetree/bindings/clock/img,boston-clock.txt | 31 ---------
.../bindings/mfd/img,boston-platform-regs.yaml | 74 ++++++++++++++++++++++
Documentation/devicetree/bindings/mips/cpus.yaml | 1 +
.../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++
arch/mips/boot/dts/img/boston.dts | 23 ++++---
5 files changed, 119 insertions(+), 43 deletions(-)
---
base-commit: 6ba6c795dc73c22ce2c86006f17c4aa802db2a60
change-id: 20240513-boston-syscon-8e315e94a894
Best regards,
--
Jiaxun Yang <[email protected]>
We certainly want subnodes of system-controller node to
be populated, add simple-mfd compatible to make that happen.
Signed-off-by: Jiaxun Yang <[email protected]>
---
arch/mips/boot/dts/img/boston.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index 72f7605d2e31..f7a2c46f1eb8 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -203,7 +203,7 @@ cpc@16200000 {
};
plat_regs: system-controller@17ffd000 {
- compatible = "img,boston-platform-regs", "syscon";
+ compatible = "img,boston-platform-regs", "syscon", "simple-mfd";
reg = <0x17ffd000 0x1000>;
clk_boston: clock {
--
2.43.0
To match actual hardware topology.
Signed-off-by: Jiaxun Yang <[email protected]>
---
arch/mips/boot/dts/img/boston.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index f7a2c46f1eb8..7379be7d46e1 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -210,13 +210,13 @@ clk_boston: clock {
compatible = "img,boston-clock";
#clock-cells = <1>;
};
- };
- reboot: syscon-reboot {
- compatible = "syscon-reboot";
- regmap = <&plat_regs>;
- offset = <0x10>;
- mask = <0x10>;
+ reboot: syscon-reboot {
+ compatible = "syscon-reboot";
+ regmap = <&plat_regs>;
+ offset = <0x10>;
+ mask = <0x10>;
+ };
};
uart0: uart@17ffe000 {
--
2.43.0
Add devices binding for various Imagination Technologies
MIPS based Platforms.
Signed-off-by: Jiaxun Yang <[email protected]>
---
.../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/Documentation/devicetree/bindings/mips/img/devices.yaml b/Documentation/devicetree/bindings/mips/img/devices.yaml
new file mode 100644
index 000000000000..460ca96577ad
--- /dev/null
+++ b/Documentation/devicetree/bindings/mips/img/devices.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mips/img/devices.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Imagination Technologies MIPS based Platforms
+
+maintainers:
+ - Jiaxun Yang <[email protected]>
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+
+ - description: IMG Boston
+ const: img,boston
+
+ - description: IMG Marduk (Creator Ci40)
+ items:
+ - const: img,pistachio-marduk
+ - const: img,pistachio
+
+ - description: Imagination University Program MIPSfpga
+ items:
+ - const: img,xilfpga
+ - const: digilent,nexys4ddr
+
+additionalProperties: true
+
+...
--
2.43.0
There is no reason to have #interrupt-cells node for a
pci device.
Signed-off-by: Jiaxun Yang <[email protected]>
---
arch/mips/boot/dts/img/boston.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index 7379be7d46e1..bee5bd0655cd 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -131,7 +131,6 @@ pci2_root@0,0 {
#address-cells = <3>;
#size-cells = <2>;
- #interrupt-cells = <1>;
eg20t_bridge@1,0,0 {
compatible = "pci8086,8800";
@@ -139,7 +138,6 @@ eg20t_bridge@1,0,0 {
#address-cells = <3>;
#size-cells = <2>;
- #interrupt-cells = <1>;
eg20t_phub@2,0,0 {
compatible = "pci8086,8801";
--
2.43.0
Using string "IMG Boston" from bootrom.
Signed-off-by: Jiaxun Yang <[email protected]>
---
arch/mips/boot/dts/img/boston.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
index bee5bd0655cd..85d4255cfbb5 100644
--- a/arch/mips/boot/dts/img/boston.dts
+++ b/arch/mips/boot/dts/img/boston.dts
@@ -10,6 +10,7 @@ / {
#address-cells = <1>;
#size-cells = <1>;
compatible = "img,boston";
+ model = "IMG Boston";
chosen {
stdout-path = "uart0:115200";
--
2.43.0
On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote:
> Add devices binding for various Imagination Technologies
> MIPS based Platforms.
>
> Signed-off-by: Jiaxun Yang <[email protected]>
> ---
> .../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/img/devices.yaml b/Documentation/devicetree/bindings/mips/img/devices.yaml
> new file mode 100644
> index 000000000000..460ca96577ad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mips/img/devices.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mips/img/devices.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination Technologies MIPS based Platforms
> +
> +maintainers:
> + - Jiaxun Yang <[email protected]>
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:
> +
> + - description: IMG Boston
> + const: img,boston
> +
> + - description: IMG Marduk (Creator Ci40)
> + items:
> + - const: img,pistachio-marduk
> + - const: img,pistachio
> +
> + - description: Imagination University Program MIPSfpga
> + items:
> + - const: img,xilfpga
> + - const: digilent,nexys4ddr
Usually the order used here is something like:
compatible = "vendor,soc-board", "vendor,soc"
The pistachio one seems to follow that, but AFAICT "boston" is a board
and the order in this one is something like:
compatible = "vendor,soc", "vendor,generic-fpga-board"
在2024年6月12日六月 下午5:43，Conor Dooley写道：
[...]
> Usually the order used here is something like:
> compatible = "vendor,soc-board", "vendor,soc"
> The pistachio one seems to follow that, but AFAICT "boston" is a board
> and the order in this one is something like:
> compatible = "vendor,soc", "vendor,generic-fpga-board"
Boston is an FPGA & Emulation platform, so I don't have a good answer
for what should I fill as SoC.
Thanks
>
> 附件:
> * signature.asc
--
- Jiaxun
On Wed, Jun 12, 2024 at 05:57:55PM +0100, Jiaxun Yang wrote:
>
>
> 在2024年6月12日六月 下午5:43，Conor Dooley写道：
> [...]
> > Usually the order used here is something like:
> > compatible = "vendor,soc-board", "vendor,soc"
> > The pistachio one seems to follow that, but AFAICT "boston" is a board
> > and the order in this one is something like:
> > compatible = "vendor,soc", "vendor,generic-fpga-board"
>
> Boston is an FPGA & Emulation platform, so I don't have a good answer
> for what should I fill as SoC.
Ah right. Probably worth adding a little more information then as to
what the platforms are in the commit message in that case.
On Wed, Jun 12, 2024 at 12:56:27PM +0100, Jiaxun Yang wrote:
> Add devices binding for various Imagination Technologies
> MIPS based Platforms.
>
> Signed-off-by: Jiaxun Yang <[email protected]>
> ---
> .../devicetree/bindings/mips/img/devices.yaml | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
Please drop the old bindings or at least the portion covered by
this. That's
Documentation/devicetree/bindings/mips/img/pistachio-marduk.txt,
pistachio.txt, and xilfpga.txt.
Some of the description can go in here. CPU nodes are documented
elsewhere by schemas already and can be dropped. The boot protocol isn't
really DT bindings, so that belongs elsewhere if you want to keep it.
Documentation/arch/mips/ perhaps?
Rob