2024-06-15 02:00:57

by Congjie Zhou

Subject: [PATCH] fs: modify the annotation of vfs_mkdir() in fs/namei.c

modify the annotation of @dir and @dentry

Signed-off-by: Congjie Zhou <[email protected]>
---
fs/namei.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 37fb0a8aa..eda889f0c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -4095,8 +4095,8 @@ SYSCALL_DEFINE3(mknod, const char __user *, filename, umode_t, mode, unsigned, d
/**
* vfs_mkdir - create directory
* @idmap: idmap of the mount the inode was found from
- * @dir: inode of @dentry
- * @dentry: pointer to dentry of the base directory
+ * @dir: inode of parent dentry of @dentry
+ * @dentry: pointer to dentry of the new directory
* @mode: mode of the new directory
*
* Create a directory.
--
2.34.1

2024-06-15 05:27:30

by Al Viro

Subject: Re: [PATCH] fs: modify the annotation of vfs_mkdir() in fs/namei.c

On Sat, Jun 15, 2024 at 09:59:13AM +0800, Congjie Zhou wrote:
> modify the annotation of @dir and @dentry


> * vfs_mkdir - create directory
> * @idmap: idmap of the mount the inode was found from
> - * @dir: inode of @dentry
> - * @dentry: pointer to dentry of the base directory
> + * @dir: inode of parent dentry of @dentry
> + * @dentry: pointer to dentry of the new directory

Ugh... How about 'inode of the parent directory' and 'dentry
of the child to be' instead?