2015-12-08 15:40:38

by Arnd Bergmann

Subject: [PATCH] mtd: omap_elm: print interrupt resource using %pr

When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
and we get a warning about an incorrect format string for printing
the interrupt number in elm_probe:

drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]

This patch avoids the type mismatch by printing the interrupt as
a resource using the %pr format string.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/mtd/nand/omap_elm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
index 235ec7992b4c..11f174b07217 100644
--- a/drivers/mtd/nand/omap_elm.c
+++ b/drivers/mtd/nand/omap_elm.c
@@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
pdev->name, info);
if (ret) {
- dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
+ dev_err(&pdev->dev, "failure requesting %pr\n", &irq);
return ret;
}

--
2.1.0.rc2

2015-12-12 01:11:00

by Brian Norris

Subject: Re: [PATCH] mtd: omap_elm: print interrupt resource using %pr

Hi Arnd,

On Tue, Dec 08, 2015 at 04:39:45PM +0100, Arnd Bergmann wrote:
> When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> and we get a warning about an incorrect format string for printing
> the interrupt number in elm_probe:
>
> drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> This patch avoids the type mismatch by printing the interrupt as
> a resource using the %pr format string.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/mtd/nand/omap_elm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> index 235ec7992b4c..11f174b07217 100644
> --- a/drivers/mtd/nand/omap_elm.c
> +++ b/drivers/mtd/nand/omap_elm.c
> @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> pdev->name, info);
> if (ret) {
> - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> + dev_err(&pdev->dev, "failure requesting %pr\n", &irq);

drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch]

> return ret;
> }
>

Brian

2015-12-12 14:42:31

by Arnd Bergmann

Subject: Re: [PATCH] mtd: omap_elm: print interrupt resource using %pr

On Friday 11 December 2015 17:10:56 Brian Norris wrote:
> Hi Arnd,
>
> On Tue, Dec 08, 2015 at 04:39:45PM +0100, Arnd Bergmann wrote:
> > When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> > and we get a warning about an incorrect format string for printing
> > the interrupt number in elm_probe:
> >
> > drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> > drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> >
> > This patch avoids the type mismatch by printing the interrupt as
> > a resource using the %pr format string.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > ---
> > drivers/mtd/nand/omap_elm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> > index 235ec7992b4c..11f174b07217 100644
> > --- a/drivers/mtd/nand/omap_elm.c
> > +++ b/drivers/mtd/nand/omap_elm.c
> > @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> > ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> > pdev->name, info);
> > if (ret) {
> > - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> > + dev_err(&pdev->dev, "failure requesting %pr\n", &irq);
>
> drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch]

Ah, good catch. Do you want to fix it up yourself, or should I send a new version?

Arnd

2015-12-14 18:31:18

by Brian Norris

Subject: Re: [PATCH] mtd: omap_elm: print interrupt resource using %pr

On Sat, Dec 12, 2015 at 03:41:31PM +0100, Arnd Bergmann wrote:
> On Friday 11 December 2015 17:10:56 Brian Norris wrote:
> > drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch]
>
> Ah, good catch. Do you want to fix it up yourself, or should I send a new version?

Can you send a new one?