2022-06-06 03:47:37

by Leonard Göhrs

Subject: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32

According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
the VDD line and not to some single-purpose fixed regulator.
Set the EEPROM supply according to the diagram to eliminate this parent-less
regulator.

[1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections

Signed-off-by: Leonard Göhrs <[email protected]>
---
arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
index e997c4953fd1..935b7084b5a2 100644
--- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
@@ -50,12 +50,6 @@ retram: retram@38000000 {
no-map;
};
};
-
- reg_sip_eeprom: regulator_eeprom {
- compatible = "regulator-fixed";
- regulator-name = "sip_eeprom";
- regulator-always-on;
- };
};

&i2c4 {
@@ -204,7 +198,7 @@ pmic_watchdog: watchdog {

sip_eeprom: eeprom@50 {
compatible = "atmel,24c32";
- vcc-supply = <&reg_sip_eeprom>;
+ vcc-supply = <&vdd>;
reg = <0x50>;
};
};
--
2.30.2

2022-06-06 04:23:14

by Ahmad Fatoum

Subject: Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32

On 03.06.22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
>
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
>
> Signed-off-by: Leonard Göhrs <[email protected]>

Acked-by: Ahmad Fatoum <[email protected]>

Thanks,
Ahmad

> ---
> arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@38000000 {
> no-map;
> };
> };
> -
> - reg_sip_eeprom: regulator_eeprom {
> - compatible = "regulator-fixed";
> - regulator-name = "sip_eeprom";
> - regulator-always-on;
> - };
> };
>
> &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>
> sip_eeprom: eeprom@50 {
> compatible = "atmel,24c32";
> - vcc-supply = <&reg_sip_eeprom>;
> + vcc-supply = <&vdd>;
> reg = <0x50>;
> };
> };


--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-06-13 08:41:39

by Alexandre TORGUE

Subject: Re: [PATCH 2/2] ARM: dts: stm32: correct vcc-supply for eeprom on stm32mp15xx-osd32

Hi

On 6/3/22 11:44, Leonard Göhrs wrote:
> According to the OSD32MP1 Power System overview[1] the EEPROM is connected to
> the VDD line and not to some single-purpose fixed regulator.
> Set the EEPROM supply according to the diagram to eliminate this parent-less
> regulator.
>
> [1]: https://octavosystems.com/app_notes/osd32mp1-power-system-overview/#connections
>
> Signed-off-by: Leonard Göhrs <[email protected]>
> ---
> arch/arm/boot/dts/stm32mp15xx-osd32.dtsi | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> index e997c4953fd1..935b7084b5a2 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-osd32.dtsi
> @@ -50,12 +50,6 @@ retram: retram@38000000 {
> no-map;
> };
> };
> -
> - reg_sip_eeprom: regulator_eeprom {
> - compatible = "regulator-fixed";
> - regulator-name = "sip_eeprom";
> - regulator-always-on;
> - };
> };
>
> &i2c4 {
> @@ -204,7 +198,7 @@ pmic_watchdog: watchdog {
>
> sip_eeprom: eeprom@50 {
> compatible = "atmel,24c32";
> - vcc-supply = <&reg_sip_eeprom>;
> + vcc-supply = <&vdd>;
> reg = <0x50>;
> };
> };

Applied on stm32-next.

Thanks.
Alex