2017-11-24 07:37:25

by Elena Reshetova

[permalink] [raw]
Subject: RE: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t

> On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:
> > } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
> > r = upgrade_mode(dd, mode, t->md);
> > if (r)
> > return r;
> > + refcount_inc(&dd->count);
> > }
>
> Missing here:
>
> else
> refcount_inc(&dd->count);
>
> ?

Oh, yes, thanks for catching this! I think this got unnoticed so far and patch was merged, so I am going to send a followup patch now.

Best Regards,
Elena.

>
> Alasdair


From 1584872581275790590@xxx Thu Nov 23 15:51:15 +0000 2017
X-GM-THRID: 1581761449867113637
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread