2017-07-03 08:10:56

by Arvind Yadav

Subject: [PATCH] cpufreq: intel_pstate: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
15197 2552 40 17789 457d drivers/cpufreq/intel_pstate.o

File size After adding 'const':
text data bss dec hex filename
15261 2488 40 17789 457d drivers/cpufreq/intel_pstate.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index b7de5bd..4323f94 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1212,7 +1212,7 @@ static ssize_t store_min_perf_pct(struct kobject *a, struct attribute *b,
NULL
};

-static struct attribute_group intel_pstate_attr_group = {
+static const struct attribute_group intel_pstate_attr_group = {
.attrs = intel_pstate_attributes,
};

--
1.9.1

2017-07-03 09:00:51

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: intel_pstate: constify attribute_group structures.

On 03-07-17, 13:40, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15197 2552 40 17789 457d drivers/cpufreq/intel_pstate.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 15261 2488 40 17789 457d drivers/cpufreq/intel_pstate.o
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b7de5bd..4323f94 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1212,7 +1212,7 @@ static ssize_t store_min_perf_pct(struct kobject *a, struct attribute *b,
> NULL
> };
>
> -static struct attribute_group intel_pstate_attr_group = {
> +static const struct attribute_group intel_pstate_attr_group = {
> .attrs = intel_pstate_attributes,
> };

Acked-by: Viresh Kumar <[email protected]>

--
viresh