2017-06-22 22:41:33

by Gustavo A. R. Silva

Subject: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()

Value assigned to variable _bp_ at line 415 is the same as at line 434.
This makes such variable assignment unnecessary.

Addresses-Coverity-ID: 1227025
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
kernel/debug/kdb/kdb_bp.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
index 90ff129..039a329e 100644
--- a/kernel/debug/kdb/kdb_bp.c
+++ b/kernel/debug/kdb/kdb_bp.c
@@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
* assume that the breakpoint number is desired.
*/
if (addr < KDB_MAXBPT) {
- bp = &kdb_breakpoints[addr];
lowbp = highbp = addr;
highbp++;
} else {
--
2.5.0

2017-06-23 08:06:19

by Daniel Thompson

Subject: Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc()

On 22/06/17 23:41, Gustavo A. R. Silva wrote:
> Value assigned to variable _bp_ at line 415 is the same as at line 434.
> This makes such variable assignment unnecessary.
>
> Addresses-Coverity-ID: 1227025
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>

> ---
> kernel/debug/kdb/kdb_bp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..039a329e 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv)
> * assume that the breakpoint number is desired.
> */
> if (addr < KDB_MAXBPT) {
> - bp = &kdb_breakpoints[addr];
> lowbp = highbp = addr;
> highbp++;
> } else {
>