2022-05-13 21:37:52

by ZhouJie

Subject: [PATCH] drivers:Modify the return value to void

drivers:Modify the return value to void

Signed-off-by: Zhou jie <[email protected]>
---
drivers/usb/serial/mos7720.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 1e12b5f30dcc..e944c32505da 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -239,13 +239,12 @@ static int read_mos_reg(struct usb_serial *serial, unsigned int serial_portnum,

#ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT

-static inline int mos7715_change_mode(struct mos7715_parport *mos_parport,
+static void mos7715_change_mode(struct mos7715_parport *mos_parport,
enum mos7715_pp_modes mode)
{
mos_parport->shadowECR = mode;
write_mos_reg(mos_parport->serial, dummy, MOS7720_ECR,
mos_parport->shadowECR);
- return 0;
}

static void destroy_mos_parport(struct kref *kref)
--
2.18.2

2022-05-14 02:52:41

by Oliver Neukum

Subject: Re: [PATCH] drivers:Modify the return value to void

On 12.05.22 11:32, Zhou jie wrote:
> drivers:Modify the return value to void

Hi,

technically the patch is obviously correct. Yet, it is not a good idea.
write_mos_reg() can fail and hiding errors is not a good strategy.
You'd better propagate the error.

    Regards
        Oliver