2021-05-12 03:51:34

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/pci/controller/pci-tegra.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 8069bd9..c979229 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -2539,6 +2539,7 @@ static const struct of_device_id tegra_pcie_of_match[] = {
{ .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie },
{ },
};
+MODULE_DEVICE_TABLE(of, tegra_pcie_of_match);

static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
{
--
2.6.2


2021-05-13 10:58:51

by Vidya Sagar

[permalink] [raw]
Subject: Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE

Thanks for the patch.

Reviewed-by: Vidya Sagar <[email protected]>

On 5/12/2021 9:37 AM, Zou Wei wrote:
> External email: Use caution opening links or attachments
>
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/pci/controller/pci-tegra.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 8069bd9..c979229 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2539,6 +2539,7 @@ static const struct of_device_id tegra_pcie_of_match[] = {
> { .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie },
> { },
> };
> +MODULE_DEVICE_TABLE(of, tegra_pcie_of_match);
>
> static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
> {
> --
> 2.6.2
>

2021-06-01 17:05:45

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE

On Wed, May 12, 2021 at 12:07:02PM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/pci/controller/pci-tegra.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (466.00 B)
 signature.asc (849.00 B)
 Download all attachments

2021-06-03 16:09:37

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE

On Wed, 12 May 2021 12:07:02 +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Applied to pci/tegra, thanks!

[1/1] PCI: tegra: Add missing MODULE_DEVICE_TABLE
https://git.kernel.org/lpieralisi/pci/c/7ebe6b79d7

Thanks,
Lorenzo