2020-03-18 09:08:57

by Amit Kucheria

Subject: [PATCH 1/2] dt-bindings: arm: cpus: Add kryo468 compatible

Kryo468 is found in sc7180, so add it to the list of cpu compatibles

Signed-off-by: Amit Kucheria <[email protected]>
---
Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index 7a9c3ce2dbef..57408c773b4d 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -156,6 +156,7 @@ properties:
- qcom,krait
- qcom,kryo
- qcom,kryo385
+ - qcom,kryo468
- qcom,kryo485
- qcom,scorpion

--
2.20.1

2020-03-18 09:10:19

by Amit Kucheria

Subject: [PATCH 2/2] arm64: dts: qcom: sc7180: Fix cpu compatible

"arm,armv8" compatible should only be used for software models. Replace
it with the real cpu type.

Signed-off-by: Amit Kucheria <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 8011c5fe2a31..a01dfefd90be 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -83,7 +83,7 @@

CPU0: cpu@0 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x0>;
enable-method = "psci";
next-level-cache = <&L2_0>;
@@ -100,7 +100,7 @@

CPU1: cpu@100 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x100>;
enable-method = "psci";
next-level-cache = <&L2_100>;
@@ -114,7 +114,7 @@

CPU2: cpu@200 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x200>;
enable-method = "psci";
next-level-cache = <&L2_200>;
@@ -128,7 +128,7 @@

CPU3: cpu@300 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x300>;
enable-method = "psci";
next-level-cache = <&L2_300>;
@@ -142,7 +142,7 @@

CPU4: cpu@400 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x400>;
enable-method = "psci";
next-level-cache = <&L2_400>;
@@ -156,7 +156,7 @@

CPU5: cpu@500 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x500>;
enable-method = "psci";
next-level-cache = <&L2_500>;
@@ -170,7 +170,7 @@

CPU6: cpu@600 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x600>;
enable-method = "psci";
next-level-cache = <&L2_600>;
@@ -184,7 +184,7 @@

CPU7: cpu@700 {
device_type = "cpu";
- compatible = "arm,armv8";
+ compatible = "qcom,kryo468";
reg = <0x0 0x700>;
enable-method = "psci";
next-level-cache = <&L2_700>;
--
2.20.1

2020-03-18 17:26:15

by Stephen Boyd

Subject: Re: [PATCH 1/2] dt-bindings: arm: cpus: Add kryo468 compatible

Quoting Amit Kucheria (2020-03-18 02:08:16)
> Kryo468 is found in sc7180, so add it to the list of cpu compatibles
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2020-03-18 17:27:05

by Stephen Boyd

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Fix cpu compatible

Quoting Amit Kucheria (2020-03-18 02:08:17)
> "arm,armv8" compatible should only be used for software models. Replace
> it with the real cpu type.
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---

Maybe add a fixes tag too?

Reviewed-by: Stephen Boyd <[email protected]>

2020-03-19 08:34:07

by Rajendra Nayak

Subject: Re: [PATCH 1/2] dt-bindings: arm: cpus: Add kryo468 compatible

On 3/18/2020 2:38 PM, Amit Kucheria wrote:
> Kryo468 is found in sc7180, so add it to the list of cpu compatibles
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---

Reviewed-by: Rajendra Nayak <[email protected]>

> Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
> index 7a9c3ce2dbef..57408c773b4d 100644
> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -156,6 +156,7 @@ properties:
> - qcom,krait
> - qcom,kryo
> - qcom,kryo385
> + - qcom,kryo468
> - qcom,kryo485
> - qcom,scorpion
>
>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2020-03-19 08:35:27

by Rajendra Nayak

Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Fix cpu compatible

On 3/18/2020 2:38 PM, Amit Kucheria wrote:
> "arm,armv8" compatible should only be used for software models. Replace
> it with the real cpu type.
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---

Reviewed-by: Rajendra Nayak <[email protected]>

> arch/arm64/boot/dts/qcom/sc7180.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 8011c5fe2a31..a01dfefd90be 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -83,7 +83,7 @@
>
> CPU0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x0>;
> enable-method = "psci";
> next-level-cache = <&L2_0>;
> @@ -100,7 +100,7 @@
>
> CPU1: cpu@100 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x100>;
> enable-method = "psci";
> next-level-cache = <&L2_100>;
> @@ -114,7 +114,7 @@
>
> CPU2: cpu@200 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x200>;
> enable-method = "psci";
> next-level-cache = <&L2_200>;
> @@ -128,7 +128,7 @@
>
> CPU3: cpu@300 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x300>;
> enable-method = "psci";
> next-level-cache = <&L2_300>;
> @@ -142,7 +142,7 @@
>
> CPU4: cpu@400 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x400>;
> enable-method = "psci";
> next-level-cache = <&L2_400>;
> @@ -156,7 +156,7 @@
>
> CPU5: cpu@500 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x500>;
> enable-method = "psci";
> next-level-cache = <&L2_500>;
> @@ -170,7 +170,7 @@
>
> CPU6: cpu@600 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x600>;
> enable-method = "psci";
> next-level-cache = <&L2_600>;
> @@ -184,7 +184,7 @@
>
> CPU7: cpu@700 {
> device_type = "cpu";
> - compatible = "arm,armv8";
> + compatible = "qcom,kryo468";
> reg = <0x0 0x700>;
> enable-method = "psci";
> next-level-cache = <&L2_700>;
>

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2020-03-30 23:06:55

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: arm: cpus: Add kryo468 compatible

On Wed, 18 Mar 2020 14:38:16 +0530, Amit Kucheria wrote:
> Kryo468 is found in sc7180, so add it to the list of cpu compatibles
>
> Signed-off-by: Amit Kucheria <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>