2010-02-20 00:12:11

by Roel Kluin

Subject: [PATCH] ARM: misplaced parentheses?

The parentheses appear misplaced.

Signed-off-by: Roel Kluin <[email protected]>
---
Correct?

diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c
index 0b35826..5f61fd4 100644
--- a/arch/arm/mach-u300/gpio.c
+++ b/arch/arm/mach-u300/gpio.c
@@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
for (i = 0; i < U300_GPIO_MAX; i++) {
val = 0;
for (j = 0; j < 8; j++)
- val |= (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
+ val |= (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
local_irq_save(flags);
writel(val, virtbase + U300_GPIO_PXPER + i * U300_GPIO_PORTX_SPACING);
local_irq_restore(flags);

2010-02-23 15:03:32

by Linus Walleij

Subject: RE: [PATCH] ARM: misplaced parentheses?

[Roel]

> The parentheses appear misplaced.
>
> Signed-off-by: Roel Kluin <[email protected]>
> ---
> Correct?
>
> diff --git a/arch/arm/mach-u300/gpio.c b/arch/arm/mach-u300/gpio.c
> index 0b35826..5f61fd4 100644
> --- a/arch/arm/mach-u300/gpio.c
> +++ b/arch/arm/mach-u300/gpio.c
> @@ -546,7 +546,7 @@ static void gpio_set_initial_values(void)
> for (i = 0; i < U300_GPIO_MAX; i++) {
> val = 0;
> for (j = 0; j < 8; j++)
> - val |=
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP)) << j;
> + val |=
> (u32)((u300_gpio_config[i][j].pull_up == DISABLE_PULL_UP) << j);
> local_irq_save(flags);
> writel(val, virtbase + U300_GPIO_PXPER + i *
> U300_GPIO_PORTX_SPACING);
> local_irq_restore(flags);

Acked-by: Linus Walleij <[email protected]>

BTW this should go in through Russells patch tracker, can you
put it there?
http://www.arm.linux.org.uk/developer/patches/

Linus Walleij

2010-02-23 22:42:55

by Roel Kluin

Subject: Re: [PATCH] ARM: misplaced parentheses?

>> The parentheses appear misplaced.

> Acked-by: Linus Walleij <[email protected]>
>
> BTW this should go in through Russells patch tracker, can you
> put it there?

Ok, its here:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=5956/1

Thanks, Roel