2022-12-07 06:12:54

by Kunihiko Hayashi

[permalink] [raw]
Subject: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example

Rename the parent node to the generic node name "syscon".

Signed-off-by: Kunihiko Hayashi <[email protected]>
---
.../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
index 14a8c0215cc6..186fc550af4c 100644
--- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
@@ -69,7 +69,7 @@ examples:
- |
// The UniPhier pinctrl should be a subnode of a "syscon" compatible node.

- soc-glue@5f800000 {
+ syscon@5f800000 {
compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
reg = <0x5f800000 0x2000>;

--
2.25.1


2022-12-08 08:39:25

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example

On 07/12/2022 06:53, Kunihiko Hayashi wrote:
> Rename the parent node to the generic node name "syscon".
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> index 14a8c0215cc6..186fc550af4c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
> @@ -69,7 +69,7 @@ examples:
> - |
> // The UniPhier pinctrl should be a subnode of a "syscon" compatible node.
>
> - soc-glue@5f800000 {
> + syscon@5f800000 {
> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd", "syscon";
> reg = <0x5f800000 0x2000>;
>

Not visible in the diff but this is a poor example. It has only
compatible! Drop the parent node instead and extend the pinctrl node to
show complete picture of pinctrl.

Best regards,
Krzysztof

2022-12-08 15:36:49

by Kunihiko Hayashi

[permalink] [raw]
Subject: Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in uniphier-pinctrl example

On 2022/12/08 17:07, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Rename the parent node to the generic node name "syscon".
>>
>> Signed-off-by: Kunihiko Hayashi <[email protected]>
>> ---
>> .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> index 14a8c0215cc6..186fc550af4c 100644
>> ---
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> +++
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> @@ -69,7 +69,7 @@ examples:
>> - |
>> // The UniPhier pinctrl should be a subnode of a "syscon" compatible
>> node.
>>
>> - soc-glue@5f800000 {
>> + syscon@5f800000 {
>> compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd",
>> "syscon";
>> reg = <0x5f800000 0x2000>;
>>
>
> Not visible in the diff but this is a poor example. It has only
> compatible! Drop the parent node instead and extend the pinctrl node to
> show complete picture of pinctrl.

I should add some child nodes of groups and pin attributes as an example
from the devicetree.

Thank you,

---
Best Regards
Kunihiko Hayashi