2023-04-10 06:46:38

by Zhijian Li (Fujitsu)

Subject: [PATCH for-next 1/3] RDMA/rtrs: Remove duplicate cq_num assignment

line 1701 and 1713 are duplicate:
> 1701 cq_num = max_send_wr + max_recv_wr;
1702 /* alloc iu to recv new rkey reply when server reports flags set */
1703 if (clt_path->flags & RTRS_MSG_NEW_RKEY_F || con->c.cid == 0) {
1704 con->rsp_ius = rtrs_iu_alloc(cq_num, sizeof(*rsp),
1705 GFP_KERNEL,
1706 clt_path->s.dev->ib_dev,
1707 DMA_FROM_DEVICE,
1708 rtrs_clt_rdma_done);
1709 if (!con->rsp_ius)
1710 return -ENOMEM;
1711 con->queue_num = cq_num;
1712 }
> 1713 cq_num = max_send_wr + max_recv_wr;

Signed-off-by: Li Zhijian <[email protected]>
---
drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index 80abf45a197a..c2065fc33a56 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -1710,7 +1710,6 @@ static int create_con_cq_qp(struct rtrs_clt_con *con)
return -ENOMEM;
con->queue_num = cq_num;
}
- cq_num = max_send_wr + max_recv_wr;
cq_vector = con->cpu % clt_path->s.dev->ib_dev->num_comp_vectors;
if (con->c.cid >= clt_path->s.irq_con_num)
err = rtrs_cq_qp_create(&clt_path->s, &con->c, max_send_sge,
--
2.29.2

2023-04-10 13:11:12

by Guoqing Jiang

Subject: Re: [PATCH for-next 1/3] RDMA/rtrs: Remove duplicate cq_num assignment

On 4/10/23 14:43, Li Zhijian wrote:
> line 1701 and 1713 are duplicate:
>> 1701 cq_num = max_send_wr + max_recv_wr;
> 1702 /* alloc iu to recv new rkey reply when server reports flags set */
> 1703 if (clt_path->flags & RTRS_MSG_NEW_RKEY_F || con->c.cid == 0) {
> 1704 con->rsp_ius = rtrs_iu_alloc(cq_num, sizeof(*rsp),
> 1705 GFP_KERNEL,
> 1706 clt_path->s.dev->ib_dev,
> 1707 DMA_FROM_DEVICE,
> 1708 rtrs_clt_rdma_done);
> 1709 if (!con->rsp_ius)
> 1710 return -ENOMEM;
> 1711 con->queue_num = cq_num;
> 1712 }
>> 1713 cq_num = max_send_wr + max_recv_wr;
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index 80abf45a197a..c2065fc33a56 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1710,7 +1710,6 @@ static int create_con_cq_qp(struct rtrs_clt_con *con)
> return -ENOMEM;
> con->queue_num = cq_num;
> }
> - cq_num = max_send_wr + max_recv_wr;
> cq_vector = con->cpu % clt_path->s.dev->ib_dev->num_comp_vectors;
> if (con->c.cid >= clt_path->s.irq_con_num)
> err = rtrs_cq_qp_create(&clt_path->s, &con->c, max_send_sge,

Acked-by: Guoqing Jiang <[email protected]>

Thanks,
Guoqing

2023-04-19 10:46:12

by Jinpu Wang

Subject: Re: [PATCH for-next 1/3] RDMA/rtrs: Remove duplicate cq_num assignment

On Mon, Apr 10, 2023 at 8:43 AM Li Zhijian <[email protected]> wrote:
>
> line 1701 and 1713 are duplicate:
> > 1701 cq_num = max_send_wr + max_recv_wr;
> 1702 /* alloc iu to recv new rkey reply when server reports flags set */
> 1703 if (clt_path->flags & RTRS_MSG_NEW_RKEY_F || con->c.cid == 0) {
> 1704 con->rsp_ius = rtrs_iu_alloc(cq_num, sizeof(*rsp),
> 1705 GFP_KERNEL,
> 1706 clt_path->s.dev->ib_dev,
> 1707 DMA_FROM_DEVICE,
> 1708 rtrs_clt_rdma_done);
> 1709 if (!con->rsp_ius)
> 1710 return -ENOMEM;
> 1711 con->queue_num = cq_num;
> 1712 }
> > 1713 cq_num = max_send_wr + max_recv_wr;
>
> Signed-off-by: Li Zhijian <[email protected]>
Thx!
Acked-by: Jack Wang <[email protected]>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index 80abf45a197a..c2065fc33a56 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1710,7 +1710,6 @@ static int create_con_cq_qp(struct rtrs_clt_con *con)
> return -ENOMEM;
> con->queue_num = cq_num;
> }
> - cq_num = max_send_wr + max_recv_wr;
> cq_vector = con->cpu % clt_path->s.dev->ib_dev->num_comp_vectors;
> if (con->c.cid >= clt_path->s.irq_con_num)
> err = rtrs_cq_qp_create(&clt_path->s, &con->c, max_send_sge,
> --
> 2.29.2
>