On Mon, 19 Sep 2016, Paul Burton wrote:
> Make use of the generic syscon-reboot driver to reboot the Malta board,
> reducing the amount of platform code it requires.
>
> Signed-off-by: Paul Burton <[email protected]>
> ---
This has broken reboot support, all I get now is:
reboot: Restarting system
Unable to restart system
Reboot failed -- System halted
at which point I need to issue a serial BREAK to regain control of the
board and get back to YAMON; fortunately the board is wired for that.
See attached config.
Maciej
Hi Maciej,
On Saturday, 22 October 2016 10:08:57 BST Maciej W. Rozycki wrote:
> On Mon, 19 Sep 2016, Paul Burton wrote:
> > Make use of the generic syscon-reboot driver to reboot the Malta board,
> > reducing the amount of platform code it requires.
> >
> > Signed-off-by: Paul Burton <[email protected]>
> > ---
>
> This has broken reboot support, all I get now is:
>
> reboot: Restarting system
> Unable to restart system
> Reboot failed -- System halted
>
> at which point I need to issue a serial BREAK to regain control of the
> board and get back to YAMON; fortunately the board is wired for that.
This was already reported over here:
https://www.linux-mips.org/archives/linux-mips/2016-10/msg00120.html
These 2 patches fix it:
https://patchwork.linux-mips.org/patch/14395/
https://patchwork.linux-mips.org/patch/14396/
I've asked Ralf if we can get those, along with a few others, in ASAP -
preferrably for -rc3.
Thanks,
Paul
Hi Paul,
> > This has broken reboot support, all I get now is:
> >
> > reboot: Restarting system
> > Unable to restart system
> > Reboot failed -- System halted
> >
> > at which point I need to issue a serial BREAK to regain control of the
> > board and get back to YAMON; fortunately the board is wired for that.
>
> This was already reported over here:
>
> https://www.linux-mips.org/archives/linux-mips/2016-10/msg00120.html
>
> These 2 patches fix it:
>
> https://patchwork.linux-mips.org/patch/14395/
> https://patchwork.linux-mips.org/patch/14396/
Thanks, good to know and sorry to raise a late alarm then.
As it happens the board I've been fiddling with has been temporarily
sitting idle, so I went ahead and verified that these changes have indeed
removed the regression in my configuration. So you've got a confirmation
from a real Malta hardware user now too (QEMU may have its own quirks).
> I've asked Ralf if we can get those, along with a few others, in ASAP -
> preferrably for -rc3.
As these are fixes to a functional regression I also recommend merging
them ASAP.
Maciej