2019-10-07 07:24:15

by Carlo Caione

Subject: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

Hi,
I bisected an issue down to commit f7fac17ca925 "xhci: Convert
xhci_handshake() to use readl_poll_timeout_atomic()".

Setup:
XPS 9370 + Thunderbolt dock Dell TB16

Issue:
The laptop is unable to go to sleep. It never really goes to sleep and
after a few seconds the USB dies.

Log:
https://termbin.com/icix

Cheers!

--
Carlo Caione

2019-10-07 08:12:59

by Mathias Nyman

Subject: Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

On 7.10.2019 10.21, Carlo Caione wrote:
> Hi,
> I bisected an issue down to commit f7fac17ca925 "xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()".
>
> Setup:
> XPS 9370 + Thunderbolt dock Dell TB16
>
> Issue:
> The laptop is unable to go to sleep. It never really goes to sleep and after a few seconds the USB dies.
>
> Log:
> https://termbin.com/icix
>
> Cheers!
>

Does the below patch help? Greg just applied it to his usb-linus branch.

ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend()
Link: https://lore.kernel.org/r/[email protected]

-Mathias

2019-10-07 08:28:57

by Carlo Caione

Subject: Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

On 07/10/2019 09:13, Mathias Nyman wrote:

/cut
> Does the below patch help?  Greg just applied it to his usb-linus branch.
>
> ac343366846a xhci: Increase STS_SAVE timeout in xhci_suspend()
> Link:
> https://lore.kernel.org/r/[email protected]

Yes. That patch fixes the issue.

Thank you,

--
Carlo Caione