2022-01-11 13:23:09

by Tudor Ambarus

Subject: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size

PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
register being truncated to offset x = 21, causing error correction to
fail if more than 22 bit errors and if 24 or 32 bit error correction
was supported.

Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
Signed-off-by: Tudor Ambarus <[email protected]>
Cc: <[email protected]> # 4.13.x
---
v2:
- update commit description
- Cc [email protected]

arch/arm/boot/dts/sama5d2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 09c741e8ecb8..c700c3b19e4c 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
pmecc: ecc-engine@f8014070 {
compatible = "atmel,sama5d2-pmecc";
reg = <0xf8014070 0x490>,
- <0xf8014500 0x100>;
+ <0xf8014500 0x200>;
};
};

--
2.25.1

2022-01-11 13:34:54

by Alexander Dahl

Subject: Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size

Hei hei,

Am Dienstag, 11. Januar 2022, 14:23:01 CET schrieb Tudor Ambarus:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
>
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <[email protected]>
> Cc: <[email protected]> # 4.13.x

Acked-by: Alexander Dahl <[email protected]>

Greets
Alex

> ---
> v2:
> - update commit description
> - Cc [email protected]
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
> pmecc: ecc-engine@f8014070 {
> compatible = "atmel,sama5d2-pmecc";
> reg = <0xf8014070 0x490>,
> - <0xf8014500 0x100>;
> + <0xf8014500 0x200>;
> };
> };

2022-02-24 15:59:36

by Nicolas Ferre

Subject: Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size

On 11/01/2022 at 14:23, Tudor Ambarus wrote:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
>
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <[email protected]>
> Cc: <[email protected]> # 4.13.x

Acked-by: Nicolas Ferre <[email protected]>

Even if it's a fix, as we have this bug for a long time and that we are
already at rc5 of the stabilization phase, I take it in at91-dt branch
for 5.18 and not in another "fixes" batch.

Best regards,
Nicolas

> ---
> v2:
> - update commit description
> - Cc [email protected]
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
> pmecc: ecc-engine@f8014070 {
> compatible = "atmel,sama5d2-pmecc";
> reg = <0xf8014070 0x490>,
> - <0xf8014500 0x100>;
> + <0xf8014500 0x200>;
> };
> };
>


--
Nicolas Ferre