2015-06-22 07:09:04

by Valentin Rothberg

Subject: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one

Hi Chuck,

your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules
into one") has shown up in linux next-20150620. The commit merges
SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into
SUNRPC_XPRT_RDMA, but misses to update references in Documentation,
see:

Documentation/filesystems/nfs/nfs-rdma.txt:142:
SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER config options
that both
Documentation/filesystems/nfs/nfs-rdma.txt:242:
(CONFIG_SUNRPC_XPRT_RDMA_SERVER=m in kernel config), load the RDMA
Documentation/filesystems/nfs/nfs-rdma.txt:263:
(CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA
client

I guess that commit 731d5cca8272 ("Documentation: NFS/RDMA: Document
separate Kconfig symbols") needs to be reverted as well.

I detected this issue with scripts/checkkconfigsymbols.py.

Kind regards,
Valentin

2015-07-06 07:37:03

by Valentin Rothberg

Subject: Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one

On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg
<[email protected]> wrote:
> Hi Chuck,
>
> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules
> into one") has shown up in linux next-20150620. The commit merges
> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into
> SUNRPC_XPRT_RDMA, but misses to update references in Documentation,
> see:
>
> Documentation/filesystems/nfs/nfs-rdma.txt:142:
> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER config options
> that both
> Documentation/filesystems/nfs/nfs-rdma.txt:242:
> (CONFIG_SUNRPC_XPRT_RDMA_SERVER=m in kernel config), load the RDMA
> Documentation/filesystems/nfs/nfs-rdma.txt:263:
> (CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA
> client
>
> I guess that commit 731d5cca8272 ("Documentation: NFS/RDMA: Document
> separate Kconfig symbols") needs to be reverted as well.
>
> I detected this issue with scripts/checkkconfigsymbols.py.
>
> Kind regards,
> Valentin

Hi,

this is just a kind reminder that the issue above is now present in v4.2-rc1.

Kind regards,
Valentin

2015-07-06 15:30:52

by Chuck Lever III

Subject: Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one

Hi Valentin-


On Jul 6, 2015, at 3:36 AM, Valentin Rothberg <[email protected]> wrote:

> On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg
> <[email protected]> wrote:
>> Hi Chuck,
>>
>> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules
>> into one") has shown up in linux next-20150620. The commit merges
>> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into
>> SUNRPC_XPRT_RDMA, but misses to update references in Documentation,
>> see:
>>
>> Documentation/filesystems/nfs/nfs-rdma.txt:142:
>> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER config options
>> that both
>> Documentation/filesystems/nfs/nfs-rdma.txt:242:
>> (CONFIG_SUNRPC_XPRT_RDMA_SERVER=m in kernel config), load the RDMA
>> Documentation/filesystems/nfs/nfs-rdma.txt:263:
>> (CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA
>> client
>>
>> I guess that commit 731d5cca8272 ("Documentation: NFS/RDMA: Document
>> separate Kconfig symbols") needs to be reverted as well.
>>
>> I detected this issue with scripts/checkkconfigsymbols.py.
>>
>> Kind regards,
>> Valentin
>
> Hi,
>
> this is just a kind reminder that the issue above is now present in v4.2-rc1.

I somehow missed your previous note. You can start by reverting
commit 731d5cca8272.

--
Chuck Lever

2015-07-08 20:41:34

by J. Bruce Fields

Subject: Re: Documentation: rpcrdma: Merge svcrdma and xprtrdma modules into one

On Mon, Jul 06, 2015 at 11:30:26AM -0400, Chuck Lever wrote:
> Hi Valentin-
>
>
> On Jul 6, 2015, at 3:36 AM, Valentin Rothberg <[email protected]> wrote:
>
> > On Mon, Jun 22, 2015 at 9:08 AM, Valentin Rothberg
> > <[email protected]> wrote:
> >> Hi Chuck,
> >>
> >> your commit ffe1f0df5862 ("rpcrdma: Merge svcrdma and xprtrdma modules
> >> into one") has shown up in linux next-20150620. The commit merges
> >> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER into
> >> SUNRPC_XPRT_RDMA, but misses to update references in Documentation,
> >> see:
> >>
> >> Documentation/filesystems/nfs/nfs-rdma.txt:142:
> >> SUNRPC_XPRT_RDMA_CLIENT and SUNRPC_XPRT_RDMA_SERVER config options
> >> that both
> >> Documentation/filesystems/nfs/nfs-rdma.txt:242:
> >> (CONFIG_SUNRPC_XPRT_RDMA_SERVER=m in kernel config), load the RDMA
> >> Documentation/filesystems/nfs/nfs-rdma.txt:263:
> >> (CONFIG_SUNRPC_XPRT_RDMA_CLIENT=m in kernel config), load the RDMA
> >> client
> >>
> >> I guess that commit 731d5cca8272 ("Documentation: NFS/RDMA: Document
> >> separate Kconfig symbols") needs to be reverted as well.
> >>
> >> I detected this issue with scripts/checkkconfigsymbols.py.
> >>
> >> Kind regards,
> >> Valentin
> >
> > Hi,
> >
> > this is just a kind reminder that the issue above is now present in v4.2-rc1.
>
> I somehow missed your previous note. You can start by reverting
> commit 731d5cca8272.

OK, queueing up that revert for 4.3.

--b.