2022-09-27 14:12:46

by Geert Uytterhoeven

Subject: [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI

The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
solely on ACPI for matching. Hence add a dependency on ACPI, to prevent
asking the user about this driver when configuring a kernel without ACPI
support.

Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/perf/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
index 44c07ea487f4482a..341010f20b777905 100644
--- a/drivers/perf/Kconfig
+++ b/drivers/perf/Kconfig
@@ -185,7 +185,7 @@ config APPLE_M1_CPU_PMU

config ALIBABA_UNCORE_DRW_PMU
tristate "Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver"
- depends on ARM64 || COMPILE_TEST
+ depends on (ARM64 && ACPI) || COMPILE_TEST
help
Support for Driveway PMU events monitoring on Yitian 710 DDR
Sub-system.
--
2.25.1

2022-10-07 14:05:09

by Will Deacon

Subject: Re: [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI

On Tue, Sep 27, 2022 at 03:37:16PM +0200, Geert Uytterhoeven wrote:
> The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
> solely on ACPI for matching. Hence add a dependency on ACPI, to prevent
> asking the user about this driver when configuring a kernel without ACPI
> support.
>
> Fixes: cf7b61073e4526ca ("drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/perf/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 44c07ea487f4482a..341010f20b777905 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -185,7 +185,7 @@ config APPLE_M1_CPU_PMU
>
> config ALIBABA_UNCORE_DRW_PMU
> tristate "Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver"
> - depends on ARM64 || COMPILE_TEST
> + depends on (ARM64 && ACPI) || COMPILE_TEST
> help
> Support for Driveway PMU events monitoring on Yitian 710 DDR
> Sub-system.

Acked-by: Will Deacon <[email protected]>

Another one for Catalin to queue as a fix.

Will

2022-10-07 16:57:44

by Catalin Marinas

Subject: Re: [PATCH] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI

On Tue, 27 Sep 2022 15:37:16 +0200, Geert Uytterhoeven wrote:
> The Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver relies
> solely on ACPI for matching. Hence add a dependency on ACPI, to prevent
> asking the user about this driver when configuring a kernel without ACPI
> support.
>
>

Applied to arm64 (for-next/core), thanks!

[1/1] drivers/perf: ALIBABA_UNCORE_DRW_PMU should depend on ACPI
https://git.kernel.org/arm64/c/e08d07dd9f80

--
Catalin