2022-08-23 02:43:42

by chenlifu

Subject: [PATCH -next] x86/tsc: Make art_related_clocksource static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

arch/x86/kernel/tsc.c:53:20: warning:
symbol 'art_related_clocksource' was not declared. Should it be static?

Signed-off-by: Chen Lifu <[email protected]>
---
arch/x86/kernel/tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index cafacb2e58cc..a78e73da4a74 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -49,11 +49,11 @@ static DEFINE_STATIC_KEY_FALSE(__use_tsc);
int tsc_clocksource_reliable;

static u32 art_to_tsc_numerator;
static u32 art_to_tsc_denominator;
static u64 art_to_tsc_offset;
-struct clocksource *art_related_clocksource;
+static struct clocksource *art_related_clocksource;

struct cyc2ns {
struct cyc2ns_data data[2]; /* 0 + 2*16 = 32 */
seqcount_latch_t seq; /* 32 + 4 = 36 */

--
2.37.1

2022-10-08 09:31:44

by chenlifu

Subject: Re: [PATCH -next] x86/tsc: Make art_related_clocksource static

在 2022/8/23 10:18, Chen Lifu 写道:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> arch/x86/kernel/tsc.c:53:20: warning:
> symbol 'art_related_clocksource' was not declared. Should it be static?
>
> Signed-off-by: Chen Lifu <[email protected]>
> ---
> arch/x86/kernel/tsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index cafacb2e58cc..a78e73da4a74 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -49,11 +49,11 @@ static DEFINE_STATIC_KEY_FALSE(__use_tsc);
> int tsc_clocksource_reliable;
>
> static u32 art_to_tsc_numerator;
> static u32 art_to_tsc_denominator;
> static u64 art_to_tsc_offset;
> -struct clocksource *art_related_clocksource;
> +static struct clocksource *art_related_clocksource;
>
> struct cyc2ns {
> struct cyc2ns_data data[2]; /* 0 + 2*16 = 32 */
> seqcount_latch_t seq; /* 32 + 4 = 36 */
>

friendly ping ...

2022-10-17 14:39:14

by tip-bot2 for Jacob Pan

Subject: [tip: x86/cleanups] x86/tsc: Make art_related_clocksource static

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID: 3548eda8ae284d6d412d59f11cd20fc7df05362b
Gitweb: https://git.kernel.org/tip/3548eda8ae284d6d412d59f11cd20fc7df05362b
Author: Chen Lifu <[email protected]>
AuthorDate: Tue, 23 Aug 2022 10:18:21 +08:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Mon, 17 Oct 2022 16:20:48 +02:00

x86/tsc: Make art_related_clocksource static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

arch/x86/kernel/tsc.c:53:20: warning:
symbol 'art_related_clocksource' was not declared. Should it be static?

Signed-off-by: Chen Lifu <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
arch/x86/kernel/tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index cafacb2..a78e73d 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -51,7 +51,7 @@ int tsc_clocksource_reliable;
static u32 art_to_tsc_numerator;
static u32 art_to_tsc_denominator;
static u64 art_to_tsc_offset;
-struct clocksource *art_related_clocksource;
+static struct clocksource *art_related_clocksource;

struct cyc2ns {
struct cyc2ns_data data[2]; /* 0 + 2*16 = 32 */