On Wed, Oct 19, 2022 at 12:56:18PM +0300, Alexander Atanasov wrote:
> Update the inflated memory in the mm core on change.
That says what this does, but not why it is needed.
Please expand on this.
Also, is this actually fixing a bug? Is it a new feature? Something
else?
thanks,
greg k-h
On 19.10.22 13:26, Greg Kroah-Hartman wrote:
> On Wed, Oct 19, 2022 at 12:56:18PM +0300, Alexander Atanasov wrote:
>> Update the inflated memory in the mm core on change.
>
> That says what this does, but not why it is needed.
>
> Please expand on this.
>
> Also, is this actually fixing a bug? Is it a new feature? Something
> else?
The whole series is about adding a new feature - providing access to the
balloon inflated memory amount - it's in the cover letter. Should I
repeat it for every driver that implements it?
I've organized it classically:
- prepare
- add infra
- use the infra
What can I improve here?
--
Regards,
Alexander Atanasov
On Wed, Oct 19, 2022 at 01:38:13PM +0300, Alexander Atanasov wrote:
> On 19.10.22 13:26, Greg Kroah-Hartman wrote:
> > On Wed, Oct 19, 2022 at 12:56:18PM +0300, Alexander Atanasov wrote:
> > > Update the inflated memory in the mm core on change.
> >
> > That says what this does, but not why it is needed.
> >
> > Please expand on this.
> >
> > Also, is this actually fixing a bug? Is it a new feature? Something
> > else?
>
> The whole series is about adding a new feature - providing access to the
> balloon inflated memory amount - it's in the cover letter. Should I repeat
> it for every driver that implements it?
Each commit needs to justify why it is needed on its own. You do not
provide the needed information here at all to be able to review and
understand if this commit is even correct or needed.
thanks,
greg k-h