2022-11-09 16:40:55

by Krzysztof Kozlowski

Subject: Re: [PATCH 3/5] ARM: dts: nanobone: Enable I2C temperature sensor

On 09/11/2022 17:09, Mark Jackson wrote:
> The NanoBone platform supports a temperature sensor on the I2C bus.
>
> Signed-off-by: Mark Jackson <[email protected]>
> ---
> arch/arm/boot/dts/am335x-nano.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index cecc2afaeff4..2be831927af6 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -212,6 +212,11 @@ &uart5 {
> status = "okay";
> };
>
> +temperature-sensor@48 {
> + compatible = "lm75";
> + reg = <0x48>;
> +};

This should not work - you put the node in some random place.

Best regards,
Krzysztof

2022-11-09 17:22:52

by Mark Jackson

Subject: Re: [PATCH 3/5] ARM: dts: nanobone: Enable I2C temperature sensor

On Wed, 9 Nov 2022 at 16:23, Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 09/11/2022 17:09, Mark Jackson wrote:
> > The NanoBone platform supports a temperature sensor on the I2C bus.
> >
> > Signed-off-by: Mark Jackson <[email protected]>
> > ---
> > arch/arm/boot/dts/am335x-nano.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> > index cecc2afaeff4..2be831927af6 100644
> > --- a/arch/arm/boot/dts/am335x-nano.dts
> > +++ b/arch/arm/boot/dts/am335x-nano.dts
> > @@ -212,6 +212,11 @@ &uart5 {
> > status = "okay";
> > };
> >
> > +temperature-sensor@48 {
> > + compatible = "lm75";
> > + reg = <0x48>;
> > +};
>
> This should not work - you put the node in some random place.

Ah yes, that should be within the I2C block.
I'll fix that.

Cheers
Mark J.