2020-07-10 13:52:29

by Thara Gopinath

[permalink] [raw]
Subject: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type

Extend thermal trip point type property to include "cold" trip type
indicating point in the temperature domain below which a warming action
must be intiated.

Signed-off-by: Thara Gopinath <[email protected]>
---
Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
index f78bec19ca35..1689d9ba1471 100644
--- a/Documentation/devicetree/bindings/thermal/thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/thermal.txt
@@ -87,6 +87,7 @@ Required properties:
"active": A trip point to enable active cooling
"passive": A trip point to enable passive cooling
"hot": A trip point to notify emergency
+ "cold": A trip point to enable warming
"critical": Hardware not reliable.
Type: string

--
2.25.1


2020-07-13 15:06:32

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type

On 10/07/2020 15:51, Thara Gopinath wrote:
> Extend thermal trip point type property to include "cold" trip type
> indicating point in the temperature domain below which a warming action
> must be intiated.
>
> Signed-off-by: Thara Gopinath <[email protected]>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index f78bec19ca35..1689d9ba1471 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -87,6 +87,7 @@ Required properties:
> "active": A trip point to enable active cooling
> "passive": A trip point to enable passive cooling
> "hot": A trip point to notify emergency
> + "cold": A trip point to enable warming
> "critical": Hardware not reliable.
> Type: string


thermal.txt should have been removed. Perhaps, a patch is missing. The
thermal.txt has been converted into 3 yaml schema.

The change should be in thermal-zones.yaml.


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2020-07-13 17:01:40

by Thara Gopinath

[permalink] [raw]
Subject: Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type



On 7/13/20 11:05 AM, Daniel Lezcano wrote:
> On 10/07/2020 15:51, Thara Gopinath wrote:
>> Extend thermal trip point type property to include "cold" trip type
>> indicating point in the temperature domain below which a warming action
>> must be intiated.
>>
>> Signed-off-by: Thara Gopinath <[email protected]>
>> ---
>> Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
>> index f78bec19ca35..1689d9ba1471 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>> @@ -87,6 +87,7 @@ Required properties:
>> "active": A trip point to enable active cooling
>> "passive": A trip point to enable passive cooling
>> "hot": A trip point to notify emergency
>> + "cold": A trip point to enable warming
>> "critical": Hardware not reliable.
>> Type: string
>
>
> thermal.txt should have been removed. Perhaps, a patch is missing. The
> thermal.txt has been converted into 3 yaml schema.
>
> The change should be in thermal-zones.yaml.

Hi Daniel..

Thanks for the review. My bad.. I will fix this in the next version.
I can send a patch removing thermal.txt as well


>
>

--
Warm Regards
Thara

2020-07-13 17:04:36

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type

On 13/07/2020 19:01, Thara Gopinath wrote:
>
>
> On 7/13/20 11:05 AM, Daniel Lezcano wrote:
>> On 10/07/2020 15:51, Thara Gopinath wrote:
>>> Extend thermal trip point type property to include "cold" trip type
>>> indicating point in the temperature domain below which a warming action
>>> must be intiated.
>>>
>>> Signed-off-by: Thara Gopinath <[email protected]>
>>> ---
>>>   Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> index f78bec19ca35..1689d9ba1471 100644
>>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>>> @@ -87,6 +87,7 @@ Required properties:
>>>       "active":    A trip point to enable active cooling
>>>       "passive":    A trip point to enable passive cooling
>>>       "hot":        A trip point to notify emergency
>>> +    "cold":        A trip point to enable warming
>>>       "critical":    Hardware not reliable.
>>>     Type: string
>>
>>
>> thermal.txt should have been removed. Perhaps, a patch is missing. The
>> thermal.txt has been converted into 3 yaml schema.
>>
>> The change should be in thermal-zones.yaml.
>
> Hi Daniel..
>
> Thanks for the review. My bad.. I will fix this in the next version.
> I can send a patch removing thermal.txt as well

Yes, sure.

Thanks


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog