2024-05-07 13:38:01

by Xiu Jianfeng

Subject: [PATCH v3 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool

alloc_mem_cgroup_per_node_info() returns int that doesn't map to any
errno error code. The only existing caller doesn't really need an error
code so change the the function to return bool (true on success) because
this is slightly less confusing and more consistent with the other code.

Signed-off-by: Xiu Jianfeng <[email protected]>
Acked-by: Michal Hocko <[email protected]>
---
mm/memcontrol.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index feb6651ee1e8..5d4da23264fa 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -5642,13 +5642,13 @@ struct mem_cgroup *mem_cgroup_get_from_ino(unsigned long ino)
}
#endif

-static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node)
+static bool alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node)
{
struct mem_cgroup_per_node *pn;

pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, node);
if (!pn)
- return 1;
+ return false;

pn->lruvec_stats = kzalloc_node(sizeof(struct lruvec_stats),
GFP_KERNEL_ACCOUNT, node);
@@ -5664,11 +5664,11 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node)
pn->memcg = memcg;

memcg->nodeinfo[node] = pn;
- return 0;
+ return true;
fail:
kfree(pn->lruvec_stats);
kfree(pn);
- return 1;
+ return false;
}

static void free_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node)
@@ -5741,7 +5741,7 @@ static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent)
}

for_each_node(node)
- if (alloc_mem_cgroup_per_node_info(memcg, node))
+ if (!alloc_mem_cgroup_per_node_info(memcg, node))
goto fail;

if (memcg_wb_domain_init(memcg, GFP_KERNEL))
--
2.34.1

2024-05-07 14:27:29

by Shakeel Butt

Subject: Re: [PATCH v3 -next] mm: memcg: make alloc_mem_cgroup_per_node_info() return bool

On Tue, May 07, 2024 at 01:23:24PM +0000, Xiu Jianfeng wrote:
> alloc_mem_cgroup_per_node_info() returns int that doesn't map to any
> errno error code. The only existing caller doesn't really need an error
> code so change the the function to return bool (true on success) because
> this is slightly less confusing and more consistent with the other code.
>
> Signed-off-by: Xiu Jianfeng <[email protected]>
> Acked-by: Michal Hocko <[email protected]>

Acked-by: Shakeel Butt <[email protected]>