2019-03-24 23:23:32

by Kangjie Lu

Subject: [PATCH] media: tuners: fix a missing check for regmap_write_bits

regmap_write_bits could fail and thus deserves a check.

The fix returns its error code upstream in case it fails.

Signed-off-by: Kangjie Lu <[email protected]>
---
drivers/media/tuners/tda18250.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
index 20d10ef45ab6..36ede1b02d23 100644
--- a/drivers/media/tuners/tda18250.c
+++ b/drivers/media/tuners/tda18250.c
@@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)

/* charge pump */
ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
+ if (ret)
+ goto err;

return 0;
err:
--
2.17.1

2019-03-27 15:13:36

by Mukesh Ojha

Subject: Re: [PATCH] media: tuners: fix a missing check for regmap_write_bits

On 3/25/2019 4:51 AM, Kangjie Lu wrote:
> regmap_write_bits could fail and thus deserves a check.
>
> The fix returns its error code upstream in case it fails.
>
> Signed-off-by: Kangjie Lu <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh
> ---
> drivers/media/tuners/tda18250.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
> index 20d10ef45ab6..36ede1b02d23 100644
> --- a/drivers/media/tuners/tda18250.c
> +++ b/drivers/media/tuners/tda18250.c
> @@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)
>
> /* charge pump */
> ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
> + if (ret)
> + goto err;
>
> return 0;
> err:

2019-04-04 22:25:08

by Sean Young

Subject: Re: [PATCH] media: tuners: fix a missing check for regmap_write_bits

On Sun, Mar 24, 2019 at 06:21:10PM -0500, Kangjie Lu wrote:
> regmap_write_bits could fail and thus deserves a check.
>
> The fix returns its error code upstream in case it fails.

Has this been tested on real hardware?

Sean

>
> Signed-off-by: Kangjie Lu <[email protected]>
> ---
> drivers/media/tuners/tda18250.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
> index 20d10ef45ab6..36ede1b02d23 100644
> --- a/drivers/media/tuners/tda18250.c
> +++ b/drivers/media/tuners/tda18250.c
> @@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)
>
> /* charge pump */
> ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
> + if (ret)
> + goto err;
>
> return 0;
> err:
> --
> 2.17.1